Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Unified Diff: third_party/WebKit/Source/core/html/HTMLFrameElementBase.h

Issue 2631233003: Avoid mutating frame owner when detaching a provisional frame. (Closed)
Patch Set: Fix test to actually test the changed behavior. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/HTMLFrameElementBase.h
diff --git a/third_party/WebKit/Source/core/html/HTMLFrameElementBase.h b/third_party/WebKit/Source/core/html/HTMLFrameElementBase.h
index 2369fe5c8815455545c8da30cf7de35fdaf4f747..b4784525a02a63cabf43762d0000c2f2bd54d94b 100644
--- a/third_party/WebKit/Source/core/html/HTMLFrameElementBase.h
+++ b/third_party/WebKit/Source/core/html/HTMLFrameElementBase.h
@@ -34,9 +34,9 @@ class CORE_EXPORT HTMLFrameElementBase : public HTMLFrameOwnerElement {
bool canContainRangeEndPoint() const final { return false; }
// FrameOwner overrides:
- ScrollbarMode scrollingMode() const override { return m_scrollingMode; }
- int marginWidth() const override { return m_marginWidth; }
- int marginHeight() const override { return m_marginHeight; }
+ ScrollbarMode scrollingMode() const final { return m_scrollingMode; }
+ int marginWidth() const final { return m_marginWidth; }
+ int marginHeight() const final { return m_marginHeight; }
protected:
HTMLFrameElementBase(const QualifiedName&, Document&);

Powered by Google App Engine
This is Rietveld 408576698