Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLFrameElementBase.h

Issue 2631233003: Avoid mutating frame owner when detaching a provisional frame. (Closed)
Patch Set: Fix test to actually test the changed behavior. Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Simon Hausmann <hausmann@kde.org> 4 * (C) 2000 Simon Hausmann <hausmann@kde.org>
5 * Copyright (C) 2004, 2006, 2008, 2009 Apple Inc. All rights reserved. 5 * Copyright (C) 2004, 2006, 2008, 2009 Apple Inc. All rights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 16 matching lines...) Expand all
27 #include "core/CoreExport.h" 27 #include "core/CoreExport.h"
28 #include "core/html/HTMLFrameOwnerElement.h" 28 #include "core/html/HTMLFrameOwnerElement.h"
29 29
30 namespace blink { 30 namespace blink {
31 31
32 class CORE_EXPORT HTMLFrameElementBase : public HTMLFrameOwnerElement { 32 class CORE_EXPORT HTMLFrameElementBase : public HTMLFrameOwnerElement {
33 public: 33 public:
34 bool canContainRangeEndPoint() const final { return false; } 34 bool canContainRangeEndPoint() const final { return false; }
35 35
36 // FrameOwner overrides: 36 // FrameOwner overrides:
37 ScrollbarMode scrollingMode() const override { return m_scrollingMode; } 37 ScrollbarMode scrollingMode() const final { return m_scrollingMode; }
38 int marginWidth() const override { return m_marginWidth; } 38 int marginWidth() const final { return m_marginWidth; }
39 int marginHeight() const override { return m_marginHeight; } 39 int marginHeight() const final { return m_marginHeight; }
40 40
41 protected: 41 protected:
42 HTMLFrameElementBase(const QualifiedName&, Document&); 42 HTMLFrameElementBase(const QualifiedName&, Document&);
43 43
44 void parseAttribute(const AttributeModificationParams&) override; 44 void parseAttribute(const AttributeModificationParams&) override;
45 InsertionNotificationRequest insertedInto(ContainerNode*) override; 45 InsertionNotificationRequest insertedInto(ContainerNode*) override;
46 void didNotifySubtreeInsertionsToDocument() final; 46 void didNotifySubtreeInsertionsToDocument() final;
47 void attachLayoutTree(const AttachContext& = AttachContext()) override; 47 void attachLayoutTree(const AttachContext& = AttachContext()) override;
48 48
49 // FIXME: Remove this method once we have input routing in the browser 49 // FIXME: Remove this method once we have input routing in the browser
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
81 81
82 inline bool isHTMLFrameElementBase(const HTMLElement& element) { 82 inline bool isHTMLFrameElementBase(const HTMLElement& element) {
83 return isHTMLFrameElement(element) || isHTMLIFrameElement(element); 83 return isHTMLFrameElement(element) || isHTMLIFrameElement(element);
84 } 84 }
85 85
86 DEFINE_HTMLELEMENT_TYPE_CASTS_WITH_FUNCTION(HTMLFrameElementBase); 86 DEFINE_HTMLELEMENT_TYPE_CASTS_WITH_FUNCTION(HTMLFrameElementBase);
87 87
88 } // namespace blink 88 } // namespace blink
89 89
90 #endif // HTMLFrameElementBase_h 90 #endif // HTMLFrameElementBase_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698