Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 2631183002: [clang-format] Don't derive pointer alignment (Closed)

Created:
3 years, 11 months ago by Clemens Hammacher
Modified:
3 years, 11 months ago
CC:
v8-reviews_googlegroups.com, v8-team_google.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[clang-format] Don't derive pointer alignment In V8, we always want the pointer alignment to be left, i.e. "Foo* foo" instead of "Foo *foo". R=jochen@chromium.org NOTRY=true Review-Url: https://codereview.chromium.org/2631183002 Cr-Commit-Position: refs/heads/master@{#42390} Committed: https://chromium.googlesource.com/v8/v8/+/29563017073b3571952c8434c81c3de117501a39

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M .clang-format View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
Clemens Hammacher
3 years, 11 months ago (2017-01-16 15:28:29 UTC) #1
jochen (gone - plz use gerrit)
lgtm
3 years, 11 months ago (2017-01-16 15:40:41 UTC) #7
Clemens Hammacher
@v8-team: Heads-up: I plan to land this CL tomorrow if no one objects. As nearly ...
3 years, 11 months ago (2017-01-16 15:59:07 UTC) #8
titzer
On 2017/01/16 15:59:07, Clemens Hammacher wrote: > @v8-team: Heads-up: I plan to land this CL ...
3 years, 11 months ago (2017-01-16 17:11:41 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2631183002/1
3 years, 11 months ago (2017-01-17 09:26:43 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-17 09:28:25 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/29563017073b3571952c8434c81c3de1175...

Powered by Google App Engine
This is Rietveld 408576698