Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 2631173002: Scope cleanup: add default params for variable declaring functions. (Closed)

Created:
3 years, 11 months ago by marja
Modified:
3 years, 11 months ago
Reviewers:
Toon Verwaest
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Scope cleanup: add default params for variable declaring functions. This makes it clearer which places are creating variables which are something else than NORMAL_VARIABLE + kCreatedInitialized. BUG= Review-Url: https://codereview.chromium.org/2631173002 Cr-Commit-Position: refs/heads/master@{#42395} Committed: https://chromium.googlesource.com/v8/v8/+/31beac34a2857259d53bea075f072b37210175c9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -32 lines) Patch
M src/ast/scopes.h View 3 chunks +13 lines, -9 lines 0 comments Download
M src/ast/scopes.cc View 6 chunks +8 lines, -13 lines 0 comments Download
M src/parsing/parser.cc View 5 chunks +5 lines, -10 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
marja
ptal; just some small cleanups, it's cleaner to have the default params so that we ...
3 years, 11 months ago (2017-01-16 15:18:11 UTC) #2
Toon Verwaest
lgtm
3 years, 11 months ago (2017-01-17 09:53:25 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2631173002/1
3 years, 11 months ago (2017-01-17 10:06:41 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-17 10:31:58 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/31beac34a2857259d53bea075f072b37210...

Powered by Google App Engine
This is Rietveld 408576698