third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp - Issue 2631133002: Make CompositeEditCommand::insertNodeBefore() to update layout for hasEditableStyle()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp

Issue 2631133002: Make CompositeEditCommand::insertNodeBefore() to update layout for hasEditableStyle() (Closed)

Patch Set: 2017-01-16T20:09:30 Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/BUILD.gn ('k') | third_party/WebKit/Source/core/editing/commands/CompositeEditCommandTest.cpp » ('j') | third_party/WebKit/Source/core/editing/commands/CompositeEditCommandTest.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp

diff --git a/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp b/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp

index 57d9249d5ad8eb6200db2002d0776811d8d54a27..082cd875d9a28b3a27e7945644619f9c16d4f745 100644

--- a/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp

+++ b/third_party/WebKit/Source/core/editing/commands/CompositeEditCommand.cpp

@@ -379,6 +379,9 @@ void CompositeEditCommand::insertNodeBefore(

EditingState* editingState,

ShouldAssumeContentIsAlwaysEditable shouldAssumeContentIsAlwaysEditable) {

DCHECK_NE(document().body(), refChild);

+ // TODO(editing-dev): Use of updateStyleAndLayoutIgnorePendingStylesheets

+ // needs to be audited. See http://crbug.com/590369 for more details.

+ document().updateStyleAndLayoutIgnorePendingStylesheets();

ABORT_EDITING_COMMAND_IF(!hasEditableStyle(*refChild->parentNode()) &&

refChild->parentNode()->inActiveDocument());

applyCommandToComposite(