Make CompositeEditCommand::insertNodeBefore() to update layout for hasEditableStyle()

Make CompositeEditCommand::insertNodeBefore() to update layout for hasEditableStyle()

This patch makes |CompositeEditCommand::insertNodeBefore()| to update layout for
|hasEditableStyle()| to get correct value of |hasEditableStyle()| for sanity
of implementation and a preparation of [1], which may update layout during
construction of |insertNodeBeforeCommand| by computing |VisibleSelection| in
|EditCommand| constructor.

This patch also add regression test cases for
|CompositeEditCommand::insertNodeBefore()| along with new behavior for calling
it on dirty layout tree.

[1] http://crrev.com/2637013002: Make FrameSelection to hold non-canonicalized
positions

BUG=n/a
TEST=run_webkit_unittests --gtest_filter=CompositeEditCommandTest.insertNodeBeforeWithDirtyLayoutTree

Review-Url: https://codereview.chromium.org/2631133002
Cr-Commit-Position: refs/heads/master@{#444329}
Committed: https://chromium.googlesource.com/chromium/src/+/acefebccb68d844f98e746f7877360070abe8349

[yosin_UTC9, 2017-01-16 09:27:42]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-16 09:27:51]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-16 11:02:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-16 11:02:37]

Dry run: This issue passed the CQ dry run.

[yosin_UTC9, 2017-01-16 11:10:27]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-16 11:10:41]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-16 12:59:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-16 12:59:55]

Dry run: This issue passed the CQ dry run.

[yosin_UTC9, 2017-01-17 01:40:26]

Description was changed from

==========
2017-01-16T18:26:23

2017-01-16T18:23:50

BUG=
==========

to

==========
Make CompositeEditCommand::insertNodeBefore() to update layout for
hasEditableStyle()

This patch makes |CompositeEditCommand::insertNodeBefore()| to update layout for
|hasEditableStyle()| to get correct value of |hasEditableStyle()| for sanity
of implementation and a preparation of [1], which may update layout during
construction of |insertNodeBeforeCommand| by computing |VisibleSelection| in
|EditCommand| constructor.

This patch also add regression test cases for
|CompositeEditCommand::insertNodeBefore()| along with new behavior for calling
it on dirty layout tree.

[1] http://crrev.com/2637013002: Make FrameSelection to hold non-canonicalized
positions

BUG=n/a
TEST=run_webkit_unittests
--gtest_filter=CompositeEditCommandTest.insertNodeBeforeWithDirtyLayoutTree
==========

[yosin_UTC9, 2017-01-17 01:40:39]

yosin@chromium.org changed reviewers:
+ xiaochengh@chromium.org, yoichio@chromium.org

[yosin_UTC9, 2017-01-17 01:40:39]

PTAL

[yoichio, 2017-01-17 02:11:09]

On 2017/01/17 01:40:39, Yosi_UTC9 wrote:
> PTAL

Did you test performance for speedometor and/or other DOM mutations?
https://cs.chromium.org/chromium/src/tools/perf/benchmarks/speedometer.py

[yosin_UTC9, 2017-01-17 02:22:12]

On 2017/01/17 at 02:11:09, yoichio wrote:
> On 2017/01/17 01:40:39, Yosi_UTC9 wrote:
> > PTAL
> 
> Did you test performance for speedometor and/or other DOM mutations?
> https://cs.chromium.org/chromium/src/tools/perf/benchmarks/speedometer.py
No. We'll watch performance regression after commit.
If performance is regressed, we'll seek solution.

[yosin_UTC9, 2017-01-17 02:26:27]

On 2017/01/17 at 02:22:12, Yosi_UTC9 wrote:
> On 2017/01/17 at 02:11:09, yoichio wrote:
> > On 2017/01/17 01:40:39, Yosi_UTC9 wrote:
> > > PTAL
> > 
> > Did you test performance for speedometor and/or other DOM mutations?
> > https://cs.chromium.org/chromium/src/tools/perf/benchmarks/speedometer.py
> No. We'll watch performance regression after commit.
> If performance is regressed, we'll seek solution.

BTW, It seems Speedometer doesn't use InsertNodeBeforeCommand.

[yoichio, 2017-01-18 02:29:17]

https://codereview.chromium.org/2631133002/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/core/editing/commands/CompositeEditCommandTest.cpp
(right):

https://codereview.chromium.org/2631133002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/commands/CompositeEditCommandTest.cpp:52:
SampleCommand& sample = *new SampleCommand(document());
Why do you use reference than simple pointer?

[yosin_UTC9, 2017-01-18 03:44:14]

https://codereview.chromium.org/2631133002/diff/20001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/core/editing/commands/CompositeEditCommandTest.cpp
(right):

https://codereview.chromium.org/2631133002/diff/20001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/editing/commands/CompositeEditCommandTest.cpp:52:
SampleCommand& sample = *new SampleCommand(document());
On 2017/01/18 at 02:29:17, yoichio wrote:
> Why do you use reference than simple pointer?

Short form of
SampleCommand* const sample = new SampleCommand(document());

And |sample.xxx()| over |sample->xxx()|

[yoichio, 2017-01-18 03:51:23]

lgtm

[yosin_UTC9, 2017-01-18 09:09:13]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2017-01-18 09:09:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-01-18 09:32:06]

On 2017/01/18 at 09:09:27, commit-bot wrote:
> CQ is trying da patch. Follow status at
>  
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

We run speedometer on ToT official build. The results are
Tot: 107.5
Call updateLayout in EditCommand ctor: 106.5

So, this patch won't make speedometer slower since calling updateLayout in ctor
is more calling of updateLayout than this patch.

[commit-bot: I haz the power, 2017-01-18 10:54:57]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484730553815700,
"parent_rev": "78d4c0d304e60af63f0a087b8b3de73c27d489b4", "commit_rev":
"acefebccb68d844f98e746f7877360070abe8349"}

[commit-bot: I haz the power, 2017-01-18 10:55:23]

Description was changed from

==========
Make CompositeEditCommand::insertNodeBefore() to update layout for
hasEditableStyle()

This patch makes |CompositeEditCommand::insertNodeBefore()| to update layout for
|hasEditableStyle()| to get correct value of |hasEditableStyle()| for sanity
of implementation and a preparation of [1], which may update layout during
construction of |insertNodeBeforeCommand| by computing |VisibleSelection| in
|EditCommand| constructor.

This patch also add regression test cases for
|CompositeEditCommand::insertNodeBefore()| along with new behavior for calling
it on dirty layout tree.

[1] http://crrev.com/2637013002: Make FrameSelection to hold non-canonicalized
positions

BUG=n/a
TEST=run_webkit_unittests
--gtest_filter=CompositeEditCommandTest.insertNodeBeforeWithDirtyLayoutTree
==========

to

==========
Make CompositeEditCommand::insertNodeBefore() to update layout for
hasEditableStyle()

This patch makes |CompositeEditCommand::insertNodeBefore()| to update layout for
|hasEditableStyle()| to get correct value of |hasEditableStyle()| for sanity
of implementation and a preparation of [1], which may update layout during
construction of |insertNodeBeforeCommand| by computing |VisibleSelection| in
|EditCommand| constructor.

This patch also add regression test cases for
|CompositeEditCommand::insertNodeBefore()| along with new behavior for calling
it on dirty layout tree.

[1] http://crrev.com/2637013002: Make FrameSelection to hold non-canonicalized
positions

BUG=n/a
TEST=run_webkit_unittests
--gtest_filter=CompositeEditCommandTest.insertNodeBeforeWithDirtyLayoutTree

Review-Url: https://codereview.chromium.org/2631133002
Cr-Commit-Position: refs/heads/master@{#444329}
Committed:
https://chromium.googlesource.com/chromium/src/+/acefebccb68d844f98e746f78773...
==========

[commit-bot: I haz the power, 2017-01-18 10:55:24]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/acefebccb68d844f98e746f78773...