[crankshaft][runtime] Initialize uninitialized double fields with hole NaN value instead of 0.0.

[crankshaft][runtime] Initialize uninitialized double fields with hole NaN value instead of 0.0.

... and ensure that we do a full store when we overwrite uninitialized values.

This cleanup is necessary for checking that constant field tracking works as expected (once landed).

BUG=v8:5495
Review-Url: https://codereview.chromium.org/2631123002
Cr-Commit-Position: refs/heads/master@{#42369}
Committed: https://chromium.googlesource.com/v8/v8/+/46134ff4b0ac6ff413e28748788cdc1294fbf69d

[Igor Sheludko, 2017-01-16 09:32:24]

Description was changed from

==========
[crankshaft] Cleanup storing to uninitialized fields



BUG=v8:5495
==========

to

==========
[crankshaft][runtime] Initialize uninitialized double fields with hole NaN value
instead of 0.0.

... and ensure that we do a full store when we overwrite uninitialized values.

This cleanup is necessary for checking that constant field tracking works as
expected (once landed).

BUG=v8:5495
==========

[Igor Sheludko, 2017-01-16 09:32:57]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-16 09:32:58]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Igor Sheludko, 2017-01-16 09:33:11]

ishell@chromium.org changed reviewers:
+ verwaest@chromium.org

[Igor Sheludko, 2017-01-16 09:33:11]

PTAL

[commit-bot: I haz the power, 2017-01-16 10:00:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-16 10:00:50]

Dry run: This issue passed the CQ dry run.

[Toon Verwaest, 2017-01-16 11:53:31]

minor comment

https://codereview.chromium.org/2631123002/diff/1/src/crankshaft/hydrogen.cc
File src/crankshaft/hydrogen.cc (right):

https://codereview.chromium.org/2631123002/diff/1/src/crankshaft/hydrogen.cc#...
src/crankshaft/hydrogen.cc:5764: if (IsTransition()) return INITIALIZING_STORE;
if IsTransition() is true, store_mode_ should just be INITIALIZING_STORE as
well...

[Igor Sheludko, 2017-01-16 11:57:34]

Patchset #2 (id:20001) has been deleted

[Igor Sheludko, 2017-01-16 11:58:26]

The CQ bit was checked by ishell@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-16 11:58:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Igor Sheludko, 2017-01-16 12:02:59]

https://codereview.chromium.org/2631123002/diff/1/src/crankshaft/hydrogen.cc
File src/crankshaft/hydrogen.cc (right):

https://codereview.chromium.org/2631123002/diff/1/src/crankshaft/hydrogen.cc#...
src/crankshaft/hydrogen.cc:5764: if (IsTransition()) return INITIALIZING_STORE;
On 2017/01/16 11:53:31, Toon Verwaest wrote:
> if IsTransition() is true, store_mode_ should just be INITIALIZING_STORE as
> well...

Done.

[Toon Verwaest, 2017-01-16 12:11:36]

lgtm

[Igor Sheludko, 2017-01-16 12:13:37]

The CQ bit was unchecked by ishell@chromium.org

[Igor Sheludko, 2017-01-16 12:13:42]

The CQ bit was checked by ishell@chromium.org

[commit-bot: I haz the power, 2017-01-16 12:13:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-16 12:26:11]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484568822040440,
"parent_rev": "bbcb33c773d46eebe65e36c1ef4ed5e5b9196fce", "commit_rev":
"46134ff4b0ac6ff413e28748788cdc1294fbf69d"}

[commit-bot: I haz the power, 2017-01-16 12:26:15]

Description was changed from

==========
[crankshaft][runtime] Initialize uninitialized double fields with hole NaN value
instead of 0.0.

... and ensure that we do a full store when we overwrite uninitialized values.

This cleanup is necessary for checking that constant field tracking works as
expected (once landed).

BUG=v8:5495
==========

to

==========
[crankshaft][runtime] Initialize uninitialized double fields with hole NaN value
instead of 0.0.

... and ensure that we do a full store when we overwrite uninitialized values.

This cleanup is necessary for checking that constant field tracking works as
expected (once landed).

BUG=v8:5495

Review-Url: https://codereview.chromium.org/2631123002
Cr-Commit-Position: refs/heads/master@{#42369}
Committed:
https://chromium.googlesource.com/v8/v8/+/46134ff4b0ac6ff413e28748788cdc1294f...
==========

[commit-bot: I haz the power, 2017-01-16 12:26:16]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/46134ff4b0ac6ff413e28748788cdc1294f...