Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Issue 2631093004: RawResourceTest: Use loadingTaskRunner to be balanced with Resource (Closed)

Created:
3 years, 11 months ago by Takashi Toyoshima
Modified:
3 years, 11 months ago
Reviewers:
yhirano
CC:
chromium-reviews, blink-reviews, loading-reviews+fetch_chromium.org, tyoshino+watch_chromium.org, Nate Chapin, gavinp+loader_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

RawResourceTest: Use loadingTaskRunner to be balanced with Resource ResourceCallback::schedule() was changed to use loadingTaskRunner instead of Timer, but RawResourceTest is still using a Timer to remove a client from a Resource. Since tests expects tasks are scheduled sequentially, we should use the same infrastructure to run asynchronous tasks for both Resource and tests. Tests work without task reordering at this point, but tests fail due to reordering if this file is moved under platform and run with TestingPlatformSupportWithMockScheduler. TEST=webkit_unit_tests --ftest_filter=RawResourceTest.AddClientDuringCallback BUG=655920 Review-Url: https://codereview.chromium.org/2631093004 Cr-Commit-Position: refs/heads/master@{#444022} Committed: https://chromium.googlesource.com/chromium/src/+/2a568e5096fc65ebf8f338288000dac8fffadc84

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -9 lines) Patch
M third_party/WebKit/Source/core/fetch/RawResourceTest.cpp View 2 chunks +10 lines, -9 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
Takashi Toyoshima
PTAL
3 years, 11 months ago (2017-01-17 08:19:42 UTC) #5
yhirano
On 2017/01/17 08:19:42, toyoshim wrote: > PTAL LGTM s/is sill use/is still using/
3 years, 11 months ago (2017-01-17 10:04:21 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2631093004/1
3 years, 11 months ago (2017-01-17 10:58:45 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-17 11:08:38 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2a568e5096fc65ebf8f338288000...

Powered by Google App Engine
This is Rietveld 408576698