Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(915)

Issue 2631063004: Roll recipe dependencies (nontrivial). (Closed)

Created:
3 years, 11 months ago by recipe-roller
Modified:
3 years, 11 months ago
Reviewers:
dtu, iannucci
CC:
chromium-reviews, infra-reviews+infra_chromium.org
Target Ref:
refs/heads/master
Project:
infra
Visibility:
Public.

Description

Roll recipe dependencies (nontrivial). This is an automated CL created by the recipe roller. This CL rolls recipe changes from upstream projects (e.g. depot_tools) into downstream projects (e.g. tools/build). Please review the expectation changes, and LGTM as normal. The recipe roller will *NOT* CQ the change itself, so you must CQ the change manually. More info is at https://goo.gl/zkKdpD. Use https://goo.gl/noib3a to file a bug (or complain) build: https://crrev.com/1b0060e03eaba685a3d59400717bdf9511c407ff [perf] Fix JSON wrapping of data sent to perf dashboard. (dtu@chromium.org) R=dtu@chromium.org Recipe-Tryjob-Bypass-Reason: Autoroller Bugdroid-Send-Email: False Review-Url: https://codereview.chromium.org/2631063004 Committed: https://chromium.googlesource.com/infra/infra/+/ade55dd9781f84690f93cd4938222dccf8b8d0c6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M infra/config/recipes.cfg View 1 chunk +1 line, -1 line 0 comments Download
M recipes/recipes/isolate_go_perf.expected/infra_linux.json View 1 chunk +1 line, -1 line 0 comments Download
M recipes/recipes/isolate_go_perf.expected/infra_win.json View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (8 generated)
recipe-roller
3 years, 11 months ago (2017-01-16 19:48:12 UTC) #1
iannucci
lgtm, but this is preetty ugly :)
3 years, 11 months ago (2017-01-20 05:36:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2631063004/1
3 years, 11 months ago (2017-01-20 05:36:12 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 05:45:52 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/infra/infra/+/ade55dd9781f84690f93cd4938222...

Powered by Google App Engine
This is Rietveld 408576698