Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issue 2631013002: Try to avoid working on zero-height column sets, when possible. (Closed)

Created:
3 years, 11 months ago by mstensho (USE GERRIT)
Modified:
3 years, 11 months ago
Reviewers:
eae
CC:
chromium-reviews, szager+layoutwatch_chromium.org, zoltan1, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, jchaffraix+rendering, blink-reviews, mstensho (USE GERRIT)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Try to avoid working on zero-height column sets, when possible. We may end up with an empty column set between two column spanners, if there is zero-height column content "separating" them. We typically have no business inside a zero-height column set, since fragmentation is impossible there. Fragmentation requires a positive fragmentainer block size to ensure content progression. So keep looking for a column set that has a height, and use that one instead, as long as its flow thread start offset is the same as the one we were requested to map to a column set. BUG=675100 Review-Url: https://codereview.chromium.org/2631013002 Cr-Commit-Position: refs/heads/master@{#443998} Committed: https://chromium.googlesource.com/chromium/src/+/cf39aa8ec1f314d198a3caa12922c254e49d1e7c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -12 lines) Patch
A third_party/WebKit/LayoutTests/fast/multicol/span/empty-block-between-spanners.html View 1 chunk +16 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/multicol/span/empty-block-with-bottom-margin-between-spanners.html View 1 chunk +15 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutMultiColumnFlowThread.cpp View 2 chunks +26 lines, -12 lines 0 comments Download

Messages

Total messages: 13 (9 generated)
mstensho (USE GERRIT)
Magic. :/
3 years, 11 months ago (2017-01-16 09:46:01 UTC) #7
eae
LGTM
3 years, 11 months ago (2017-01-17 02:53:23 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2631013002/1
3 years, 11 months ago (2017-01-17 06:06:32 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-17 07:22:26 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/cf39aa8ec1f314d198a3caa12922...

Powered by Google App Engine
This is Rietveld 408576698