Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(9)

Issue 2630993002: Update Windows build instructions. (Closed)

Created:
10 months ago by Dirk Pranke
Modified:
10 months ago
Reviewers:
danakj, brucedawson
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update Windows build instructions. This updates the windows build instructions to clarify how you need to adjust your PATH environment variable to pick up depot_tools, and to note that NTFS is required. R=brucedawson@chromium.org, danakj@chromium.org BUG=611087 Review-Url: https://codereview.chromium.org/2630993002 Cr-Commit-Position: refs/heads/master@{#444773} Committed: https://chromium.googlesource.com/chromium/src/+/4b470c5b3ffd5b74476cb3ffbcf3ff416ea30d72

Patch Set 1 #

Messages

Total messages: 10 (5 generated)
Dirk Pranke
I think I got this right, but you might want to double-check. I'm also open ...
10 months ago (2017-01-15 03:28:24 UTC) #1
Dirk Pranke
ping? @danakj, do you want to take a look at this in brucedawson's apparent absence?
10 months ago (2017-01-19 04:34:08 UTC) #4
danakj
LGTM
10 months ago (2017-01-19 17:08:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2630993002/1
10 months ago (2017-01-19 17:23:01 UTC) #7
commit-bot: I haz the power
10 months ago (2017-01-19 17:38:43 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/4b470c5b3ffd5b74476cb3ffbcf3...

Powered by Google App Engine
This is Rietveld efc10ee0f