Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2630983002: Reland "Change GN to disallow reading args defined in the same..." (Closed)

Created:
3 years, 11 months ago by Dirk Pranke
Modified:
3 years, 11 months ago
Reviewers:
brettw
CC:
chromium-reviews, Dirk Pranke, tfarina, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland "Change GN to disallow reading args defined in the same..." This re-lands r433944, "Change GN to disallow reading args defined in the same declare_args() call." The change was reverted in r439366 when we though it might be the cause of some flakiness, but that turned out to be wrong (the change was fine). TBR=brettw@chromium.org BUG=542846 Review-Url: https://codereview.chromium.org/2630983002 Cr-Commit-Position: refs/heads/master@{#443808} Committed: https://chromium.googlesource.com/chromium/src/+/c50ed7de30182bfd6d5eb36e049be98b497d13ac

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+143 lines, -25 lines) Patch
M tools/gn/docs/reference.md View 2 chunks +7 lines, -8 lines 0 comments Download
M tools/gn/functions.h View 2 chunks +11 lines, -1 line 0 comments Download
M tools/gn/functions.cc View 4 chunks +38 lines, -8 lines 0 comments Download
M tools/gn/functions_unittest.cc View 1 chunk +45 lines, -0 lines 0 comments Download
M tools/gn/parse_tree.cc View 1 chunk +6 lines, -1 line 0 comments Download
M tools/gn/scope.h View 2 chunks +10 lines, -1 line 0 comments Download
M tools/gn/scope.cc View 2 chunks +26 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
Dirk Pranke
3 years, 11 months ago (2017-01-15 02:42:09 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2630983002/1
3 years, 11 months ago (2017-01-15 02:42:13 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/c50ed7de30182bfd6d5eb36e049be98b497d13ac
3 years, 11 months ago (2017-01-15 02:58:52 UTC) #6
brettw
3 years, 11 months ago (2017-01-17 20:50:27 UTC) #7
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698