Fix race in SecurityExploitBrowserTest and SiteIsolationStatsGathererBrowserTest

Fix race in SecurityExploitBrowserTest and SiteIsolationStatsGathererBrowserTest

BUG=674545
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_tsan_rel_ng

Review-Url: https://codereview.chromium.org/2630843002
Cr-Commit-Position: refs/heads/master@{#443761}
Committed: https://chromium.googlesource.com/chromium/src/+/0fa95f0d5127fbf230f3d6cea29376f2a0c12c74

[gab, 2017-01-13 21:42:25]

Description was changed from

==========
Fix race in SecurityExploitBrowserTest.

BUG=674545
==========

to

==========
Fix race in SecurityExploitBrowserTest.

BUG=674545
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_tsan_rel_ng
==========

[gab, 2017-01-13 21:42:28]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-13 21:43:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gab, 2017-01-13 21:45:30]

gab@chromium.org changed reviewers:
+ creis@chromium.org

[gab, 2017-01-13 21:45:30]

creis@ PTAL, thanks

[gab, 2017-01-13 21:50:00]

Description was changed from

==========
Fix race in SecurityExploitBrowserTest.

BUG=674545
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_tsan_rel_ng
==========

to

==========
Fix race in SecurityExploitBrowserTest and SiteIsolationStatsGathererBrowserTest

BUG=674545
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_tsan_rel_ng
==========

[gab, 2017-01-13 21:50:07]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-13 21:50:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 22:28:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-13 22:28:23]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[Charlie Reis, 2017-01-13 22:53:22]

[CC nasko, nick]

Thanks for looking into this!  The updated tests are failing on the bots,
though.  Can you take a look?

[gab, 2017-01-14 00:09:51]

On 2017/01/13 22:53:22, Charlie Reis wrote:
> [CC nasko, nick]
> 
> Thanks for looking into this!  The updated tests are failing on the bots,
> though.  Can you take a look?

Oops indeed, can't override BrowserTestBase::SetUp() to do things after it as it
runs the test and our call doesn't happen before the test runs...
StartAcceptingConnections() needs to go in SetUpOnMainThread(), done and works
locally now.

[gab, 2017-01-14 00:09:55]

The CQ bit was checked by gab@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-14 00:10:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Charlie Reis, 2017-01-14 00:30:03]

Thanks!  LGTM.

[commit-bot: I haz the power, 2017-01-14 01:17:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-14 01:17:46]

Dry run: This issue passed the CQ dry run.

[gab, 2017-01-14 01:31:23]

The CQ bit was checked by gab@chromium.org

[commit-bot: I haz the power, 2017-01-14 01:31:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-14 01:38:11]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484357483447230,
"parent_rev": "363c1602576bbf0c2241d439ae6a87ee07007e2b", "commit_rev":
"0fa95f0d5127fbf230f3d6cea29376f2a0c12c74"}

[commit-bot: I haz the power, 2017-01-14 01:39:01]

Description was changed from

==========
Fix race in SecurityExploitBrowserTest and SiteIsolationStatsGathererBrowserTest

BUG=674545
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_tsan_rel_ng
==========

to

==========
Fix race in SecurityExploitBrowserTest and SiteIsolationStatsGathererBrowserTest

BUG=674545
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_tsan_rel_ng

Review-Url: https://codereview.chromium.org/2630843002
Cr-Commit-Position: refs/heads/master@{#443761}
Committed:
https://chromium.googlesource.com/chromium/src/+/0fa95f0d5127fbf230f3d6cea293...
==========

[commit-bot: I haz the power, 2017-01-14 01:39:02]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/0fa95f0d5127fbf230f3d6cea293...