Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 2630813002: Revert of On W3C test import, always skip large files that may fail to upload. (Closed)

Created:
3 years, 11 months ago by qyearsley
Modified:
3 years, 11 months ago
Reviewers:
jeffcarp
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, dominicc (has gone to gerrit), Dirk Pranke, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of On W3C test import, always skip large files that may fail to upload. (patchset #1 id:1 of https://codereview.chromium.org/2628913003/ ) Reason for revert: I believe that this didn't actually solve the problem properly - In the latest import, some tests are failing because they depend on files that are too large that were already checked in (in media/*), and after this change, the files are removed but the tests are still imported, causing this failure: https://build.chromium.org/p/chromium.infra.cron/builders/w3c-test-autoroller/builds/7870/steps/update%20wpt/logs/stdio Original issue's description: > On W3C test import, always skip large files that may fail to upload. > > This CL also removes a skip from W3CImportExpectations that should no > longer be necessary. > > BUG=676491 > > Review-Url: https://codereview.chromium.org/2628913003 > Cr-Commit-Position: refs/heads/master@{#443163} > Committed: https://chromium.googlesource.com/chromium/src/+/dff0c445aee94798e03534796a0af11eb459d3a9 TBR=jeffcarp@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=676491 Review-Url: https://codereview.chromium.org/2630813002 Cr-Commit-Position: refs/heads/master@{#443678} Committed: https://chromium.googlesource.com/chromium/src/+/531db5a7f975086598bf966a1d9186a00a537f9b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -40 lines) Patch
M third_party/WebKit/LayoutTests/W3CImportExpectations View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/system/filesystem.py View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/common/system/filesystem_mock.py View 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer.py View 3 chunks +1 line, -7 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_importer_unittest.py View 3 chunks +1 line, -25 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
qyearsley
Created Revert of On W3C test import, always skip large files that may fail to ...
3 years, 11 months ago (2017-01-13 20:28:19 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2630813002/1
3 years, 11 months ago (2017-01-13 20:29:09 UTC) #3
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 21:37:07 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/531db5a7f975086598bf966a1d91...

Powered by Google App Engine
This is Rietveld 408576698