extensions/browser/api/guest_view/web_view/web_view_internal_api.h - Issue 2630753003: Separate validation failures from other failures in ExecuteCodeFunction.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/guest_view/web_view/web_view_internal_api.h

Issue 2630753003: Separate validation failures from other failures in ExecuteCodeFunction. (Closed)

Patch Set: address comments Created 3 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/api/guest_view/web_view/web_view_internal_api.h

diff --git a/extensions/browser/api/guest_view/web_view/web_view_internal_api.h b/extensions/browser/api/guest_view/web_view/web_view_internal_api.h

index 3c5bf2aa07a3cf5bea41441a69649d0bff643485..486bc039c8f8996421b02bb022e7dde111f099d9 100644

--- a/extensions/browser/api/guest_view/web_view/web_view_internal_api.h

+++ b/extensions/browser/api/guest_view/web_view/web_view_internal_api.h

@@ -97,7 +97,7 @@ class WebViewInternalExecuteCodeFunction

~WebViewInternalExecuteCodeFunction() override;

// Initialize |details_| if it hasn't already been.

- bool Init() override;

+ InitResult Init() override;

bool ShouldInsertCSS() const override;

bool CanExecuteScriptOnPage() override;

// Guarded by a process ID check.