Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Side by Side Diff: extensions/browser/api/guest_view/web_view/web_view_internal_api.h

Issue 2630753003: Separate validation failures from other failures in ExecuteCodeFunction. (Closed)
Patch Set: address comments Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef EXTENSIONS_BROWSER_API_GUEST_VIEW_WEB_VIEW_WEB_VIEW_INTERNAL_API_H_ 5 #ifndef EXTENSIONS_BROWSER_API_GUEST_VIEW_WEB_VIEW_WEB_VIEW_INTERNAL_API_H_
6 #define EXTENSIONS_BROWSER_API_GUEST_VIEW_WEB_VIEW_WEB_VIEW_INTERNAL_API_H_ 6 #define EXTENSIONS_BROWSER_API_GUEST_VIEW_WEB_VIEW_WEB_VIEW_INTERNAL_API_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
(...skipping 79 matching lines...) Expand 10 before | Expand all | Expand 10 after
90 90
91 class WebViewInternalExecuteCodeFunction 91 class WebViewInternalExecuteCodeFunction
92 : public extensions::ExecuteCodeFunction { 92 : public extensions::ExecuteCodeFunction {
93 public: 93 public:
94 WebViewInternalExecuteCodeFunction(); 94 WebViewInternalExecuteCodeFunction();
95 95
96 protected: 96 protected:
97 ~WebViewInternalExecuteCodeFunction() override; 97 ~WebViewInternalExecuteCodeFunction() override;
98 98
99 // Initialize |details_| if it hasn't already been. 99 // Initialize |details_| if it hasn't already been.
100 bool Init() override; 100 InitResult Init() override;
101 bool ShouldInsertCSS() const override; 101 bool ShouldInsertCSS() const override;
102 bool CanExecuteScriptOnPage() override; 102 bool CanExecuteScriptOnPage() override;
103 // Guarded by a process ID check. 103 // Guarded by a process ID check.
104 extensions::ScriptExecutor* GetScriptExecutor() final; 104 extensions::ScriptExecutor* GetScriptExecutor() final;
105 bool IsWebView() const override; 105 bool IsWebView() const override;
106 const GURL& GetWebViewSrc() const override; 106 const GURL& GetWebViewSrc() const override;
107 bool LoadFile(const std::string& file) override; 107 bool LoadFile(const std::string& file) override;
108 108
109 private: 109 private:
110 // Loads a file url on WebUI. 110 // Loads a file url on WebUI.
(...skipping 344 matching lines...) Expand 10 before | Expand all | Expand 10 after
455 uint32_t remove_mask_; 455 uint32_t remove_mask_;
456 // Tracks any data related or parse errors. 456 // Tracks any data related or parse errors.
457 bool bad_message_; 457 bool bad_message_;
458 458
459 DISALLOW_COPY_AND_ASSIGN(WebViewInternalClearDataFunction); 459 DISALLOW_COPY_AND_ASSIGN(WebViewInternalClearDataFunction);
460 }; 460 };
461 461
462 } // namespace extensions 462 } // namespace extensions
463 463
464 #endif // EXTENSIONS_BROWSER_API_GUEST_VIEW_WEB_VIEW_WEB_VIEW_INTERNAL_API_H_ 464 #endif // EXTENSIONS_BROWSER_API_GUEST_VIEW_WEB_VIEW_WEB_VIEW_INTERNAL_API_H_
OLDNEW
« no previous file with comments | « extensions/browser/api/execute_code_function.cc ('k') | extensions/browser/api/guest_view/web_view/web_view_internal_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698