Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 2630703002: Rename Supplement::host() to Supplement::supplementable() (Closed)

Created:
3 years, 11 months ago by haraken
Modified:
3 years, 11 months ago
Reviewers:
sof
CC:
chromium-reviews, dshwang, mvanouwerkerk+watch_chromium.org, mlamouri+watch-blink_chromium.org, sof, eae+blinkwatch, feature-vr-reviews_chromium.org, timvolodine, haraken, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews-paint_chromium.org, blink-reviews, kinuko+watch, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Rename Supplement::host() to Supplement::supplementable() Supplement::host() is confusing with FrameHost since it's sometimes used as host()->frame() etc. Hence this CL renames it to something clearer. BUG=610176 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Review-Url: https://codereview.chromium.org/2630703002 Cr-Commit-Position: refs/heads/master@{#443528} Committed: https://chromium.googlesource.com/chromium/src/+/71d04138368832f6649c3ca85b4384dadde2c640

Patch Set 1 #

Patch Set 2 : temp #

Patch Set 3 : temp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -49 lines) Patch
M third_party/WebKit/Source/core/dom/CSSSelectorWatch.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/dom/DocumentParserTiming.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/FirstMeaningfulPaintDetector.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintTiming.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/timing/DOMWindowPerformance.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/beacon/NavigatorBeacon.cpp View 3 chunks +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/modules/csspaint/WindowPaintWorklet.cpp View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/donottrack/NavigatorDoNotTrack.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/geolocation/NavigatorGeolocation.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/installedapp/NavigatorInstalledApp.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/storage/DOMWindowStorage.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/vr/NavigatorVR.cpp View 1 3 chunks +7 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/platform/Supplementable.h View 1 chunk +13 lines, -11 lines 0 comments Download

Messages

Total messages: 18 (14 generated)
haraken
PTAL
3 years, 11 months ago (2017-01-13 07:01:40 UTC) #3
sof
lgtm
3 years, 11 months ago (2017-01-13 07:48:13 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2630703002/40001
3 years, 11 months ago (2017-01-13 09:08:00 UTC) #15
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 10:37:24 UTC) #18
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/71d04138368832f6649c3ca85b43...

Powered by Google App Engine
This is Rietveld 408576698