Description was changed from ========== Rename Supplement::host() to Supplement::supplementable() Supplement::host() is confusing with FrameHost since ...
3 years, 11 months ago
(2017-01-13 07:00:56 UTC)
#1
Description was changed from
==========
Rename Supplement::host() to Supplement::supplementable()
Supplement::host() is confusing with FrameHost since it's sometimes used
as host()->frame() etc. Hence this CL renames it to something clearer.
BUG=610176
==========
to
==========
Rename Supplement::host() to Supplement::supplementable()
Supplement::host() is confusing with FrameHost since it's sometimes used
as host()->frame() etc. Hence this CL renames it to something clearer.
BUG=610176
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========
Dry run: Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds/135388) ios-device-xcode-clang on ...
3 years, 11 months ago
(2017-01-13 07:04:33 UTC)
#7
Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/347798)
3 years, 11 months ago
(2017-01-13 09:01:25 UTC)
#12
CQ is committing da patch. Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484298455403150, "parent_rev": "035f36c35c4e73b55dacaddfd1530faf5ccc322d", "commit_rev": "71d04138368832f6649c3ca85b4384dadde2c640"}
3 years, 11 months ago
(2017-01-13 10:36:50 UTC)
#16
CQ is committing da patch.
Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484298455403150,
"parent_rev": "035f36c35c4e73b55dacaddfd1530faf5ccc322d", "commit_rev":
"71d04138368832f6649c3ca85b4384dadde2c640"}
commit-bot: I haz the power
Description was changed from ========== Rename Supplement::host() to Supplement::supplementable() Supplement::host() is confusing with FrameHost since ...
3 years, 11 months ago
(2017-01-13 10:37:23 UTC)
#17
Message was sent while issue was closed.
Description was changed from
==========
Rename Supplement::host() to Supplement::supplementable()
Supplement::host() is confusing with FrameHost since it's sometimes used
as host()->frame() etc. Hence this CL renames it to something clearer.
BUG=610176
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========
to
==========
Rename Supplement::host() to Supplement::supplementable()
Supplement::host() is confusing with FrameHost since it's sometimes used
as host()->frame() etc. Hence this CL renames it to something clearer.
BUG=610176
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Review-Url: https://codereview.chromium.org/2630703002
Cr-Commit-Position: refs/heads/master@{#443528}
Committed:
https://chromium.googlesource.com/chromium/src/+/71d04138368832f6649c3ca85b43...
==========
commit-bot: I haz the power
Committed patchset #3 (id:40001) as https://chromium.googlesource.com/chromium/src/+/71d04138368832f6649c3ca85b4384dadde2c640
3 years, 11 months ago
(2017-01-13 10:37:24 UTC)
#18
Issue 2630703002: Rename Supplement::host() to Supplement::supplementable()
(Closed)
Created 3 years, 11 months ago by haraken
Modified 3 years, 11 months ago
Reviewers: sof
Base URL:
Comments: 0