Revert of Convert more test helpers to base::RunLoop, fix page title checks.

Revert of Convert more test helpers to base::RunLoop, fix page title checks. (patchset #5 id:80001 of https://codereview.chromium.org/2601843002/ )

Reason for revert:
ClickModifierTest.WindowOpenBasicClickTest and ClickModifierTest.WindowOpenControlShiftClickTest become very flaky recently. Example builds are all
recorded at crbug.com/681035.

By looking at the error log file (https://build.chromium.org/p/chromium.win/builders/Win%207%20Tests%20x64%20%281%29/builds/19997/steps/browser_tests/logs/stdio), I notice that
the error comes from src\chrome\browser\ui\browser_browsertest.cc(2451) which is recently modified by this CL. Therefore the revert.


Original issue's description:
> Convert more test helpers to base::RunLoop, fix page title checks.
> 
> This CL removes the "deferred quit" from most of the touched helpers.
> 
> The exclusions are UrlCommitObserver and TestFrameNavigationObserver.
> They were already using immediate quit mode, so there is no change in
> their behavior, just cleanup.
> 
> Regarding title checks in browser_browsertest.cc: in these tests there
> is no guarantee on when the new tab will start and stop loading. It
> can start loading after WindowedNotificationObserver::Wait returns; also
> it can stop loading while we're still inside it. We can explicitly wait
> for the title to handle all these cases, and this makes the call to
> WaitForLoadStop unnecessary.
> 
> 
> BUG=668707
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
> 
> Review-Url: https://codereview.chromium.org/2601843002
> Cr-Commit-Position: refs/heads/master@{#443395}
> Committed: https://chromium.googlesource.com/chromium/src/+/e7469132628fa7bd530d68c134e4159d2cfc1804

TBR=nasko@chromium.org,pkasting@chromium.org,ahest@yandex-team.ru
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=668707, 681035
Review-Url: https://codereview.chromium.org/2630683003
Cr-Commit-Position: refs/heads/master@{#443671}
Committed: https://chromium.googlesource.com/chromium/src/+/0fe6b1a44d65f685dc90aa7ef6c2b44dca2c9667

[xlai (Olivia), 2017-01-13 21:16:05]

Created Revert of Convert more test helpers to base::RunLoop, fix page title
checks.

[xlai (Olivia), 2017-01-13 21:16:29]

Description was changed from

==========
Revert of Convert more test helpers to base::RunLoop, fix page title checks.
(patchset #5 id:80001 of https://codereview.chromium.org/2601843002/ )

Reason for revert:
ClickModifierTest.WindowOpenBasicClickTest and
ClickModifierTest.WindowOpenControlShiftClickTest become very flaky recently.
Example builds are all
recorded at crbug.com/681035.

By looking at the error log file
(https://build.chromium.org/p/chromium.win/builders/Win%207%20Tests%20x64%20%2...),
I notice that
the error comes from src\chrome\browser\ui\browser_browsertest.cc(2451) which is
recently modified by this CL. Therefore the revert.


Original issue's description:
> Convert more test helpers to base::RunLoop, fix page title checks.
> 
> This CL removes the "deferred quit" from most of the touched helpers.
> 
> The exclusions are UrlCommitObserver and TestFrameNavigationObserver.
> They were already using immediate quit mode, so there is no change in
> their behavior, just cleanup.
> 
> Regarding title checks in browser_browsertest.cc: in these tests there
> is no guarantee on when the new tab will start and stop loading. It
> can start loading after WindowedNotificationObserver::Wait returns; also
> it can stop loading while we're still inside it. We can explicitly wait
> for the title to handle all these cases, and this makes the call to
> WaitForLoadStop unnecessary.
> 
> 
> BUG=668707
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
> 
> Review-Url: https://codereview.chromium.org/2601843002
> Cr-Commit-Position: refs/heads/master@{#443395}
> Committed:
https://chromium.googlesource.com/chromium/src/+/e7469132628fa7bd530d68c134e4...

TBR=nasko@chromium.org,pkasting@chromium.org,ahest@yandex-team.ru
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=668707
==========

to

==========
Revert of Convert more test helpers to base::RunLoop, fix page title checks.
(patchset #5 id:80001 of https://codereview.chromium.org/2601843002/ )

Reason for revert:
ClickModifierTest.WindowOpenBasicClickTest and
ClickModifierTest.WindowOpenControlShiftClickTest become very flaky recently.
Example builds are all
recorded at crbug.com/681035.

By looking at the error log file
(https://build.chromium.org/p/chromium.win/builders/Win%207%20Tests%20x64%20%2...),
I notice that
the error comes from src\chrome\browser\ui\browser_browsertest.cc(2451) which is
recently modified by this CL. Therefore the revert.


Original issue's description:
> Convert more test helpers to base::RunLoop, fix page title checks.
> 
> This CL removes the "deferred quit" from most of the touched helpers.
> 
> The exclusions are UrlCommitObserver and TestFrameNavigationObserver.
> They were already using immediate quit mode, so there is no change in
> their behavior, just cleanup.
> 
> Regarding title checks in browser_browsertest.cc: in these tests there
> is no guarantee on when the new tab will start and stop loading. It
> can start loading after WindowedNotificationObserver::Wait returns; also
> it can stop loading while we're still inside it. We can explicitly wait
> for the title to handle all these cases, and this makes the call to
> WaitForLoadStop unnecessary.
> 
> 
> BUG=668707
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
> 
> Review-Url: https://codereview.chromium.org/2601843002
> Cr-Commit-Position: refs/heads/master@{#443395}
> Committed:
https://chromium.googlesource.com/chromium/src/+/e7469132628fa7bd530d68c134e4...

TBR=nasko@chromium.org,pkasting@chromium.org,ahest@yandex-team.ru
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=668707,681035
==========

[xlai (Olivia), 2017-01-13 21:16:50]

The CQ bit was checked by xlai@chromium.org

[commit-bot: I haz the power, 2017-01-13 21:17:22]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 21:18:13]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1484342210830700, "parent_rev":
"1a56e240a23b3d01c57a9bf39f9296a45eced88c", "commit_rev":
"0fe6b1a44d65f685dc90aa7ef6c2b44dca2c9667"}

[commit-bot: I haz the power, 2017-01-13 21:18:50]

Description was changed from

==========
Revert of Convert more test helpers to base::RunLoop, fix page title checks.
(patchset #5 id:80001 of https://codereview.chromium.org/2601843002/ )

Reason for revert:
ClickModifierTest.WindowOpenBasicClickTest and
ClickModifierTest.WindowOpenControlShiftClickTest become very flaky recently.
Example builds are all
recorded at crbug.com/681035.

By looking at the error log file
(https://build.chromium.org/p/chromium.win/builders/Win%207%20Tests%20x64%20%2...),
I notice that
the error comes from src\chrome\browser\ui\browser_browsertest.cc(2451) which is
recently modified by this CL. Therefore the revert.


Original issue's description:
> Convert more test helpers to base::RunLoop, fix page title checks.
> 
> This CL removes the "deferred quit" from most of the touched helpers.
> 
> The exclusions are UrlCommitObserver and TestFrameNavigationObserver.
> They were already using immediate quit mode, so there is no change in
> their behavior, just cleanup.
> 
> Regarding title checks in browser_browsertest.cc: in these tests there
> is no guarantee on when the new tab will start and stop loading. It
> can start loading after WindowedNotificationObserver::Wait returns; also
> it can stop loading while we're still inside it. We can explicitly wait
> for the title to handle all these cases, and this makes the call to
> WaitForLoadStop unnecessary.
> 
> 
> BUG=668707
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
> 
> Review-Url: https://codereview.chromium.org/2601843002
> Cr-Commit-Position: refs/heads/master@{#443395}
> Committed:
https://chromium.googlesource.com/chromium/src/+/e7469132628fa7bd530d68c134e4...

TBR=nasko@chromium.org,pkasting@chromium.org,ahest@yandex-team.ru
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=668707,681035
==========

to

==========
Revert of Convert more test helpers to base::RunLoop, fix page title checks.
(patchset #5 id:80001 of https://codereview.chromium.org/2601843002/ )

Reason for revert:
ClickModifierTest.WindowOpenBasicClickTest and
ClickModifierTest.WindowOpenControlShiftClickTest become very flaky recently.
Example builds are all
recorded at crbug.com/681035.

By looking at the error log file
(https://build.chromium.org/p/chromium.win/builders/Win%207%20Tests%20x64%20%2...),
I notice that
the error comes from src\chrome\browser\ui\browser_browsertest.cc(2451) which is
recently modified by this CL. Therefore the revert.


Original issue's description:
> Convert more test helpers to base::RunLoop, fix page title checks.
> 
> This CL removes the "deferred quit" from most of the touched helpers.
> 
> The exclusions are UrlCommitObserver and TestFrameNavigationObserver.
> They were already using immediate quit mode, so there is no change in
> their behavior, just cleanup.
> 
> Regarding title checks in browser_browsertest.cc: in these tests there
> is no guarantee on when the new tab will start and stop loading. It
> can start loading after WindowedNotificationObserver::Wait returns; also
> it can stop loading while we're still inside it. We can explicitly wait
> for the title to handle all these cases, and this makes the call to
> WaitForLoadStop unnecessary.
> 
> 
> BUG=668707
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
> 
> Review-Url: https://codereview.chromium.org/2601843002
> Cr-Commit-Position: refs/heads/master@{#443395}
> Committed:
https://chromium.googlesource.com/chromium/src/+/e7469132628fa7bd530d68c134e4...

TBR=nasko@chromium.org,pkasting@chromium.org,ahest@yandex-team.ru
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=668707,681035

Review-Url: https://codereview.chromium.org/2630683003
Cr-Commit-Position: refs/heads/master@{#443671}
Committed:
https://chromium.googlesource.com/chromium/src/+/0fe6b1a44d65f685dc90aa7ef6c2...
==========

[commit-bot: I haz the power, 2017-01-13 21:18:51]

Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/0fe6b1a44d65f685dc90aa7ef6c2...