Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1176)

Issue 2630603002: Revert of Touchpad and wheel scroll latching for ChromeOS behind flag. (Closed)

Created:
3 years, 11 months ago by sahel
Modified:
3 years, 11 months ago
Reviewers:
bokan, tdresser
CC:
chromium-reviews, jam, tdresser+watch_chromium.org, darin-cc_chromium.org, dtapuska+chromiumwatch_chromium.org, mlamouri+watch-content_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Touchpad and wheel scroll latching for ChromeOS behind flag. (patchset #3 id:100001 of https://codereview.chromium.org/2625453002/ ) Reason for revert: EXPECT_CALL(mock_input_handler_, ScrollBy(testing::_)).Times(0); line at the end of the unittest won't do anything. It doesn't break anything but it doesn't do the intended check either. I have to call Animate() after this line to do the checking. Original issue's description: > Touchpad and wheel scroll latching for ChromeOS behind flag. > > To enable latching, MouseWheelEventQueue(MWEQ) uses a timer to send GSE > events. When a fling arrives if the timer is running, MWEQ will stop it > and won't send the pending GSE. > > In input_handler_proxy, ScrollBegin is called only once in > HandleGestureFlingStart. This ScrollBegin won't do a new hittesting > because CurrentlyScrollingLayer already exists (No GSE is sent before > fling to clear the CurrentlyScrollingLayer when it's being handled). > > ScrollEnd won't get called in FlingScrollByMouseWheel for every wheel tick. > Instead, it will be called only once in CancelCurrentFlingWithoutNotifyingClient, > when the fling is over (last ScrollBy didn't scroll or fling time is terminated). > > To test locally use the --enable-features=TouchpadAndWheelScrollLatching > runtime flag. > > BUG=526463 > TEST=InputHandlerProxyTest.GestureFlingTouchpadScrollLatchingEnabled > > Review-Url: https://codereview.chromium.org/2625453002 > Cr-Commit-Position: refs/heads/master@{#443332} > Committed: https://chromium.googlesource.com/chromium/src/+/4ced61f2e1215b847fc726343aecd410db03da5c TBR=tdresser@chromium.org,bokan@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=526463

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+48 lines, -159 lines) Patch
M content/browser/renderer_host/input/mouse_wheel_event_queue.cc View 1 chunk +2 lines, -11 lines 0 comments Download
M content/renderer/input/input_handler_wrapper.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M ui/events/blink/input_handler_proxy.h View 3 chunks +1 line, -5 lines 0 comments Download
M ui/events/blink/input_handler_proxy.cc View 5 chunks +45 lines, -42 lines 0 comments Download
M ui/events/blink/input_handler_proxy_unittest.cc View 2 chunks +0 lines, -98 lines 0 comments Download

Messages

Total messages: 6 (3 generated)
sahel
Created Revert of Touchpad and wheel scroll latching for ChromeOS behind flag.
3 years, 11 months ago (2017-01-12 20:30:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2630603002/1
3 years, 11 months ago (2017-01-12 20:31:53 UTC) #3
bokan
3 years, 11 months ago (2017-01-12 20:31:56 UTC) #4
There's no need to revert the whole patch, you could just land a followup. OTOH,
if you'd prefer this, that's fine too.

Powered by Google App Engine
This is Rietveld 408576698