DescriptionRevert of Touchpad and wheel scroll latching for ChromeOS behind flag. (patchset #3 id:100001 of https://codereview.chromium.org/2625453002/ )
Reason for revert:
EXPECT_CALL(mock_input_handler_, ScrollBy(testing::_)).Times(0); line at the end of the unittest won't do anything. It doesn't break anything but it doesn't do the intended check either.
I have to call Animate() after this line to do the checking.
Original issue's description:
> Touchpad and wheel scroll latching for ChromeOS behind flag.
>
> To enable latching, MouseWheelEventQueue(MWEQ) uses a timer to send GSE
> events. When a fling arrives if the timer is running, MWEQ will stop it
> and won't send the pending GSE.
>
> In input_handler_proxy, ScrollBegin is called only once in
> HandleGestureFlingStart. This ScrollBegin won't do a new hittesting
> because CurrentlyScrollingLayer already exists (No GSE is sent before
> fling to clear the CurrentlyScrollingLayer when it's being handled).
>
> ScrollEnd won't get called in FlingScrollByMouseWheel for every wheel tick.
> Instead, it will be called only once in CancelCurrentFlingWithoutNotifyingClient,
> when the fling is over (last ScrollBy didn't scroll or fling time is terminated).
>
> To test locally use the --enable-features=TouchpadAndWheelScrollLatching
> runtime flag.
>
> BUG=526463
> TEST=InputHandlerProxyTest.GestureFlingTouchpadScrollLatchingEnabled
>
> Review-Url: https://codereview.chromium.org/2625453002
> Cr-Commit-Position: refs/heads/master@{#443332}
> Committed: https://chromium.googlesource.com/chromium/src/+/4ced61f2e1215b847fc726343aecd410db03da5c
TBR=tdresser@chromium.org,bokan@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=526463
Patch Set 1 #
Messages
Total messages: 6 (3 generated)
|