chrome/browser/resources/options/content_settings_exceptions_area.html - Issue 2630583002: Add setting to isolate zoom changes by default.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options/content_settings_exceptions_area.html

Issue 2630583002: Add setting to isolate zoom changes by default. (Closed)

Patch Set: Use code review comments for questions instead of TODOs. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/app/generated_resources.grd ('K') | « chrome/browser/resources/options/content_settings.js ('k') | chrome/browser/ui/BUILD.gn » ('j') | chrome/browser/ui/zoom/zoom_controller_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/options/content_settings_exceptions_area.html

diff --git a/chrome/browser/resources/options/content_settings_exceptions_area.html b/chrome/browser/resources/options/content_settings_exceptions_area.html

index 079080f2c7726af1a44e65dd0aec9308b6522a05..c7090797fca0792bed040b3c6fa131ac8c5e3034 100644

--- a/chrome/browser/resources/options/content_settings_exceptions_area.html

+++ b/chrome/browser/resources/options/content_settings_exceptions_area.html

@@ -145,6 +145,10 @@

</div>

+ <div id="zoom-levels-ignored-explanation"

Kevin McNee 2017/02/03 23:17:20 Is this a suitable way of informing the user that

wjmaclean 2017/02/06 16:09:07 Not sure ... we'll need a UI reviewer for that.

Kevin McNee 2017/02/06 18:26:11 Sure. Shall I split up this CL first?

wjmaclean 2017/02/06 18:48:38 Yeah, once you have the CL mostly how you want it,

+ i18n-content="zoomLevelsIgnoredExplanation"

+ hidden>

+ </div>

<div>

</span>