Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Side by Side Diff: chrome/browser/resources/options/content_settings_exceptions_area.html

Issue 2630583002: Add setting to isolate zoom changes by default. (Closed)
Patch Set: Use code review comments for questions instead of TODOs. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <div id="content-settings-exceptions-area" class="page" hidden> 1 <div id="content-settings-exceptions-area" class="page" hidden>
2 <div class="close-button"></div> 2 <div class="close-button"></div>
3 <h1></h1> 3 <h1></h1>
4 <div class="content-area"> 4 <div class="content-area">
5 <div id="exception-column-headers"> 5 <div id="exception-column-headers">
6 <div id="exception-pattern-column" i18n-content="exceptionPatternHeader"> 6 <div id="exception-pattern-column" i18n-content="exceptionPatternHeader">
7 </div> 7 </div>
8 <div id="exception-behavior-column" 8 <div id="exception-behavior-column"
9 i18n-content="exceptionBehaviorHeader" 9 i18n-content="exceptionBehaviorHeader"
10 class="exception-value-column-header"> 10 class="exception-value-column-header">
(...skipping 127 matching lines...) Expand 10 before | Expand all | Expand 10 after
138 <span class="otr-explanation" i18n-content="otrExceptionsExplanation"> 138 <span class="otr-explanation" i18n-content="otrExceptionsExplanation">
139 </span> 139 </span>
140 <list mode="otr"></list> 140 <list mode="otr"></list>
141 </div> 141 </div>
142 </div> 142 </div>
143 <div contentType="background-sync"> 143 <div contentType="background-sync">
144 <list mode="normal"></list> 144 <list mode="normal"></list>
145 </div> 145 </div>
146 <div contentType="zoomlevels"> 146 <div contentType="zoomlevels">
147 <list mode="normal"></list> 147 <list mode="normal"></list>
148 <div id="zoom-levels-ignored-explanation"
Kevin McNee 2017/02/03 23:17:20 Is this a suitable way of informing the user that
wjmaclean 2017/02/06 16:09:07 Not sure ... we'll need a UI reviewer for that.
Kevin McNee 2017/02/06 18:26:11 Sure. Shall I split up this CL first?
wjmaclean 2017/02/06 18:48:38 Yeah, once you have the CL mostly how you want it,
149 i18n-content="zoomLevelsIgnoredExplanation"
150 hidden>
151 </div>
148 <div> 152 <div>
149 <span class="otr-explanation" i18n-content="otrExceptionsExplanation"> 153 <span class="otr-explanation" i18n-content="otrExceptionsExplanation">
150 </span> 154 </span>
151 <list mode="otr"></list> 155 <list mode="otr"></list>
152 </div> 156 </div>
153 </div> 157 </div>
154 </div> 158 </div>
155 <div class="action-area"> 159 <div class="action-area">
156 <div class="hbox stretch"> 160 <div class="hbox stretch">
157 <a target="_blank" i18n-content="learnMore" 161 <a target="_blank" i18n-content="learnMore"
158 i18n-values="href:exceptionsLearnMoreUrl"></a> 162 i18n-values="href:exceptionsLearnMoreUrl"></a>
159 </div> 163 </div>
160 <div class="action-area-right"> 164 <div class="action-area-right">
161 <div class="button-strip"> 165 <div class="button-strip">
162 <button id="content-settings-exceptions-overlay-confirm" 166 <button id="content-settings-exceptions-overlay-confirm"
163 class="default-button" i18n-content="done"> 167 class="default-button" i18n-content="done">
164 </button> 168 </button>
165 </div> 169 </div>
166 </div> 170 </div>
167 </div> 171 </div>
168 </div> 172 </div>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698