Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(624)

Issue 2630533002: headless: Don't require parameters for all commands (Closed)

Created:
3 years, 11 months ago by Sami
Modified:
3 years, 11 months ago
Reviewers:
altimin, pfeldman
CC:
chromium-reviews, pfeldman, devtools-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

headless: Don't require parameters for all commands Some DevTools clients omit the "params" object for commands that don't take any parameters. Be less strict about requiring it to support these clients. BUG=679350 Review-Url: https://codereview.chromium.org/2630533002 Cr-Commit-Position: refs/heads/master@{#443598} Committed: https://chromium.googlesource.com/chromium/src/+/5a4de2c40720151cff5143b3f684698932a82af4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -6 lines) Patch
M headless/lib/browser/headless_devtools_manager_delegate.cc View 4 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
Sami
3 years, 11 months ago (2017-01-12 14:39:27 UTC) #3
altimin
lgtm lgtm
3 years, 11 months ago (2017-01-12 17:24:24 UTC) #4
pfeldman
lgtm
3 years, 11 months ago (2017-01-13 00:38:16 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2630533002/1
3 years, 11 months ago (2017-01-13 17:07:56 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 17:39:48 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5a4de2c40720151cff5143b3f684...

Powered by Google App Engine
This is Rietveld 408576698