Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Unified Diff: chrome/browser/banners/app_banner_manager.cc

Issue 2630523002: Ensure the entire page is secure for PWAs. (Closed)
Patch Set: Whitelist localhost Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/banners/app_banner_manager.cc
diff --git a/chrome/browser/banners/app_banner_manager.cc b/chrome/browser/banners/app_banner_manager.cc
index 55e03e54125f80d4a2d922e12309374743c0ca21..ce21ace08ee101fdb3c7d72ff6b21858a8b7cb63 100644
--- a/chrome/browser/banners/app_banner_manager.cc
+++ b/chrome/browser/banners/app_banner_manager.cc
@@ -22,7 +22,6 @@
#include "content/public/browser/navigation_handle.h"
#include "content/public/browser/render_frame_host.h"
#include "content/public/browser/web_contents.h"
-#include "content/public/common/origin_util.h"
#include "mojo/public/cpp/bindings/interface_request.h"
#include "services/service_manager/public/cpp/interface_provider.h"
#include "third_party/WebKit/public/platform/modules/installation/installation.mojom.h"
@@ -106,7 +105,7 @@ void AppBannerManager::RequestAppBanner(const GURL& validated_url,
// A secure origin is required to show banners, so exit early if we see the
// URL is invalid.
- if (!content::IsOriginSecure(validated_url)) {
+ if (!InstallableManager::IsContentSecure(contents)) {
ReportStatus(contents, NOT_FROM_SECURE_ORIGIN);
Stop();
return;

Powered by Google App Engine
This is Rietveld 408576698