Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(389)

Unified Diff: chrome/browser/android/webapps/add_to_homescreen_manager.cc

Issue 2630523002: Ensure the entire page is secure for PWAs. (Closed)
Patch Set: Whitelist localhost Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/webapps/add_to_homescreen_manager.cc
diff --git a/chrome/browser/android/webapps/add_to_homescreen_manager.cc b/chrome/browser/android/webapps/add_to_homescreen_manager.cc
index 3103b17ab8ef971f73bd6721b86db43230d26387..ddfa514fc8dc3048dab65afd25409693f86e33d7 100644
--- a/chrome/browser/android/webapps/add_to_homescreen_manager.cc
+++ b/chrome/browser/android/webapps/add_to_homescreen_manager.cc
@@ -17,10 +17,10 @@
#include "chrome/browser/android/webapk/webapk_install_service.h"
#include "chrome/browser/android/webapk/webapk_metrics.h"
#include "chrome/browser/banners/app_banner_settings_helper.h"
+#include "chrome/browser/installable/installable_manager.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/render_frame_host.h"
#include "content/public/browser/web_contents.h"
-#include "content/public/common/origin_util.h"
#include "jni/AddToHomescreenManager_jni.h"
#include "mojo/public/cpp/bindings/interface_request.h"
#include "services/service_manager/public/cpp/interface_provider.h"
@@ -77,7 +77,7 @@ void AddToHomescreenManager::AddShortcut(
void AddToHomescreenManager::Start(content::WebContents* web_contents) {
bool check_webapk_compatible = false;
if (ChromeWebApkHost::AreWebApkEnabled() &&
- content::IsOriginSecure(web_contents->GetLastCommittedURL())) {
+ InstallableManager::IsContentSecure(web_contents)) {
check_webapk_compatible = true;
} else {
ShowDialog();
« no previous file with comments | « no previous file | chrome/browser/banners/app_banner_manager.cc » ('j') | chrome/browser/installable/installable_manager.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698