Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2630493002: Use a pinned version of web-platform-tests/manifest. (Closed)

Created:
3 years, 11 months ago by qyearsley
Modified:
3 years, 11 months ago
Reviewers:
tkent
CC:
blink-reviews, blink-reviews-w3ctests_chromium.org, chromium-reviews, Dirk Pranke, jeffcarp
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use a pinned version of web-platform-tests/manifest. Purpose: This should prevent upstream changes in manifest from breaking import or test runner unexpectedly. BUG=678077 Review-Url: https://codereview.chromium.org/2630493002 Cr-Commit-Position: refs/heads/master@{#443158} Committed: https://chromium.googlesource.com/chromium/src/+/4aeafe93320a3851cdebc37a86ec19770c53ade9

Patch Set 1 #

Total comments: 2

Patch Set 2 : Removed redundant line in whitelist file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3505 lines, -20 lines) Patch
M third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/WPTHeads View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/WPTWhiteList View 1 2 chunks +15 lines, -3 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/.gitignore View 1 chunk +1 line, -0 lines 0 comments Download
D third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/LICENSE View 1 chunk +0 lines, -3 lines 0 comments Download
A third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/LICENSE.md View 1 chunk +33 lines, -0 lines 0 comments Download
A third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/manifest View 1 chunk +8 lines, -0 lines 0 comments Download
A third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/manifest/XMLParser.py View 1 chunk +126 lines, -0 lines 0 comments Download
A third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/manifest/__init__.py View 1 chunk +4 lines, -0 lines 0 comments Download
A third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/manifest/catalog/xhtml.dtd View 1 chunk +2125 lines, -0 lines 0 comments Download
A third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/manifest/item.py View 1 chunk +219 lines, -0 lines 0 comments Download
A third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/manifest/log.py View 1 chunk +8 lines, -0 lines 0 comments Download
A third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/manifest/manifest.py View 1 chunk +228 lines, -0 lines 0 comments Download
A third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/manifest/sourcefile.py View 1 chunk +481 lines, -0 lines 0 comments Download
A third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/manifest/update.py View 1 chunk +104 lines, -0 lines 0 comments Download
A third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/manifest/utils.py View 1 chunk +51 lines, -0 lines 0 comments Download
A third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/manifest/vcs.py View 1 chunk +91 lines, -0 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/serve/serve.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/wptserve/wptserve/handlers.py View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/wptserve/wptserve/server.py View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater_unittest.py View 2 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
qyearsley
3 years, 11 months ago (2017-01-12 00:23:17 UTC) #2
tkent
lgtm https://codereview.chromium.org/2630493002/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/WPTWhiteList File third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/WPTWhiteList (right): https://codereview.chromium.org/2630493002/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/WPTWhiteList#newcode51 third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/WPTWhiteList:51: ./tools/wptserve/wptserve/wptserve.py Looks redundant.
3 years, 11 months ago (2017-01-12 00:38:55 UTC) #3
qyearsley
https://codereview.chromium.org/2630493002/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/WPTWhiteList File third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/WPTWhiteList (right): https://codereview.chromium.org/2630493002/diff/1/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/WPTWhiteList#newcode51 third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/WPTWhiteList:51: ./tools/wptserve/wptserve/wptserve.py On 2017/01/12 at 00:38:55, tkent wrote: > Looks ...
3 years, 11 months ago (2017-01-12 02:34:44 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2630493002/20001
3 years, 11 months ago (2017-01-12 02:35:33 UTC) #7
commit-bot: I haz the power
3 years, 11 months ago (2017-01-12 05:09:59 UTC) #10
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/4aeafe93320a3851cdebc37a86ec...

Powered by Google App Engine
This is Rietveld 408576698