Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(646)

Issue 2630463003: content_browser does not provide TimeZoneMonitor interface anymore. (Closed)

Created:
3 years, 11 months ago by leonhsl(Using Gerrit)
Modified:
3 years, 11 months ago
Reviewers:
kinuko, Tom Sepez, blundell
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, darin (slow to review)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

content_browser does not provide TimeZoneMonitor interface anymore. device::mojom::TimeZoneMonitor has been changed to be hosted by Device Service, so this CL removes it from content_browser manifest, and also removes some unnecessary dependencies from content/. BUG=612341 Review-Url: https://codereview.chromium.org/2630463003 Cr-Commit-Position: refs/heads/master@{#443495} Committed: https://chromium.googlesource.com/chromium/src/+/577541d28891bae8f419183f7c73d79fc09060af

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M content/public/app/mojo/content_browser_manifest.json View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/mus/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
leonhsl(Using Gerrit)
Hi, I came across these and created this CL, PTAL, Thanks. blundell@: Overall review tsepez@: ...
3 years, 11 months ago (2017-01-12 08:38:14 UTC) #4
blundell
lgtm, thanks!
3 years, 11 months ago (2017-01-12 13:44:39 UTC) #7
Tom Sepez
lgtm
3 years, 11 months ago (2017-01-12 17:40:09 UTC) #8
kinuko
lgtm
3 years, 11 months ago (2017-01-13 04:47:00 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2630463003/1
3 years, 11 months ago (2017-01-13 04:58:46 UTC) #11
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 05:03:29 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/577541d28891bae8f419183f7c73...

Powered by Google App Engine
This is Rietveld 408576698