RenderTextHarfBuzz: Don't draw newline glyph.

RenderTextHarfBuzz: Don't draw newline glyph.

r441290 added support for multi-line selection to RenderTextHarfBuzz. It also
changed the code such that the newline glyph was drawn in some cases. This can
lead to the display of an unwanted glyph corresponding to the newline character
for certain fonts.

To fix, modify RenderTextHarfBuzz::DrawVisualText so that newline glyph is not
drawn.

BUG=680430
Review-Url: https://codereview.chromium.org/2630453005
Cr-Commit-Position: refs/heads/master@{#444272}
Committed: https://chromium.googlesource.com/chromium/src/+/6d5cb27adaa84acccadd7880f1a94cb635ebac7c

[karandeepb, 2017-01-17 00:51:31]

The CQ bit was checked by karandeepb@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-17 00:51:45]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[karandeepb, 2017-01-17 01:27:26]

Description was changed from

==========
RenderTextHarfBuzz: Don't draw newline glyph.
==========

to

==========
RenderTextHarfBuzz: Don't draw newline glyph.

r441290 added support for multi-line selection to RenderTextHarfBuzz. It also
changed the code such that the newline glyph was drawn in some cases. This can
lead to the display of an unwanted glyph corresponding to the newline character
for certain fonts.

To fix, modify RenderTextHarfBuzz::DrawVisualText so that newline glyph is not
drawn.

BUG=680430
==========

[karandeepb, 2017-01-17 01:28:24]

Patchset #1 (id:1) has been deleted

[karandeepb, 2017-01-17 01:29:16]

karandeepb@chromium.org changed reviewers:
+ msw@chromium.org

[karandeepb, 2017-01-17 01:29:16]

PTAL msw@.

[msw, 2017-01-17 18:46:59]

lgtm

[karandeepb, 2017-01-18 03:00:56]

The CQ bit was checked by karandeepb@chromium.org

[commit-bot: I haz the power, 2017-01-18 03:01:07]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 04:25:29]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484708456258420,
"parent_rev": "271557f792311061db727bd05dcedd282c1c2272", "commit_rev":
"6d5cb27adaa84acccadd7880f1a94cb635ebac7c"}

[commit-bot: I haz the power, 2017-01-18 04:26:10]

Description was changed from

==========
RenderTextHarfBuzz: Don't draw newline glyph.

r441290 added support for multi-line selection to RenderTextHarfBuzz. It also
changed the code such that the newline glyph was drawn in some cases. This can
lead to the display of an unwanted glyph corresponding to the newline character
for certain fonts.

To fix, modify RenderTextHarfBuzz::DrawVisualText so that newline glyph is not
drawn.

BUG=680430
==========

to

==========
RenderTextHarfBuzz: Don't draw newline glyph.

r441290 added support for multi-line selection to RenderTextHarfBuzz. It also
changed the code such that the newline glyph was drawn in some cases. This can
lead to the display of an unwanted glyph corresponding to the newline character
for certain fonts.

To fix, modify RenderTextHarfBuzz::DrawVisualText so that newline glyph is not
drawn.

BUG=680430

Review-Url: https://codereview.chromium.org/2630453005
Cr-Commit-Position: refs/heads/master@{#444272}
Committed:
https://chromium.googlesource.com/chromium/src/+/6d5cb27adaa84acccadd7880f1a9...
==========

[commit-bot: I haz the power, 2017-01-18 04:26:11]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/6d5cb27adaa84acccadd7880f1a9...