Plugins: Remove chrome://plugins

Plugins: Remove chrome://plugins

BUG=615738
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2630443002
Cr-Commit-Position: refs/heads/master@{#443264}
Committed: https://chromium.googlesource.com/chromium/src/+/c66a327e24ed9eb487817ed4e1669ca7f8be7016

[tommycli, 2017-01-11 22:26:22]

Description was changed from

==========
Plugins: Remove chrome://plugins

BUG=
==========

to

==========
Plugins: Remove chrome://plugins

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tommycli, 2017-01-11 22:26:25]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-11 22:27:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tommycli, 2017-01-11 22:27:59]

Description was changed from

==========
Plugins: Remove chrome://plugins

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Plugins: Remove chrome://plugins

BUG=615738
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[tommycli, 2017-01-11 22:28:31]

tommycli@chromium.org changed reviewers:
+ bauerb@chromium.org

[tommycli, 2017-01-11 22:46:37]

bauerb: PTAL.

The only reason you might be hesitant to approve this is that the Disabled
Plugin placeholder still links to chrome://plugins. However, there's that
separate CL which tries to remove it...

In any case the link doesn't help, since you can no longer enable plugins at
chrome://plugins anyways.

My recommendation is just to proceed to remove chrome://plugins and fix-up or
remove the Disabled Plugin placeholder in a separate CL. It's not a high
visibility item anyways.

[commit-bot: I haz the power, 2017-01-11 23:28:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-11 23:28:28]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[tommycli, 2017-01-12 00:59:33]

The CQ bit was checked by tommycli@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-12 01:00:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 02:55:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-12 02:55:24]

Dry run: This issue passed the CQ dry run.

[Bernhard Bauer, 2017-01-12 10:29:49]

LGTM

For the disabled plugin placeholder, can we just change the message to remove
the reference to chrome://plugins? AFAIU, plugins can still be disabled by
policy, so it might make sense to keep the placeholder itself around (although
it could get merged with the one for plugins blocked by policy, I guess. Getting
rid of that distinction will be nice anyway, as it has always confused users to
no end).

[tommycli, 2017-01-12 16:50:53]

The CQ bit was checked by tommycli@chromium.org

[commit-bot: I haz the power, 2017-01-12 16:51:21]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-12 16:56:25]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484239853535420,
"parent_rev": "5159f105dbf404212d7d8e1b24539be049f67c5d", "commit_rev":
"c66a327e24ed9eb487817ed4e1669ca7f8be7016"}

[commit-bot: I haz the power, 2017-01-12 16:56:58]

Description was changed from

==========
Plugins: Remove chrome://plugins

BUG=615738
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Plugins: Remove chrome://plugins

BUG=615738
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2630443002
Cr-Commit-Position: refs/heads/master@{#443264}
Committed:
https://chromium.googlesource.com/chromium/src/+/c66a327e24ed9eb487817ed4e166...
==========

[commit-bot: I haz the power, 2017-01-12 16:56:59]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/c66a327e24ed9eb487817ed4e166...

[Wez, 2017-02-07 19:46:05]

wez@chromium.org changed reviewers:
+ kenrb@chromium.org, wez@chromium.org

[Wez, 2017-02-07 19:46:05]

Hallo kenrb@chromium.org!
Due to a depot_tools patch which mistakenly removed the OWNERS check for
non-source files (see crbug.com/684270), the following files landed in this CL
and need a retrospective review from you:
	chrome/browser/ui/webui/plugins/plugins.mojom
Thanks,
Wez

[kenrb, 2017-02-07 19:51:24]

lgtm