Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Issue 2630423002: PaymentRequest JS should be injected only if PaymentRequest is enabled. (Closed)

Created:
3 years, 11 months ago by Moe
Modified:
3 years, 11 months ago
Reviewers:
lpromero
CC:
chromium-reviews, pkl (ping after 24h if needed), gogerald+paymentswatch_chromium.org, rouslan+payments_chromium.org, noyau+watch_chromium.org, marq+watch_chromium.org, sebsg+paymentswatch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PaymentRequest JS should be injected only if PaymentRequest is enabled. BUG=602666 Context: 1. Call to initializeWebViewForPaymentRequestI was previously moved outside of enableCurrentWebState in order to inject the script only when a URL is committed and not when enableCurrentWebState is called under other circumstances like opening the tab/switching tab etc. In enableCurrentWebState there is a check to see if PaymentRequest is enabled which by moving initializeWebViewForPaymentRequest outside, it was being skipped. Therefore this CL reintroduces that. 2. Also the order of calling enableCurrentWebState and initializeWebViewForPaymentRequest in CRWWebStateObserver method had to be changed so that the DCHECK(_webStateEnabled) won't fail. Review-Url: https://codereview.chromium.org/2630423002 Cr-Commit-Position: refs/heads/master@{#443936} Committed: https://chromium.googlesource.com/chromium/src/+/95a3c7fdd16abbc14aaf4f3e9dc0fb49fc714fdc

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -5 lines) Patch
M ios/chrome/browser/payments/payment_request_manager.mm View 2 chunks +7 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (5 generated)
lpromero
lgtm. Please add more context in the CL description or code comments.
3 years, 11 months ago (2017-01-16 19:16:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2630423002/1
3 years, 11 months ago (2017-01-16 19:29:01 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-16 20:03:07 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/95a3c7fdd16abbc14aaf4f3e9dc0...

Powered by Google App Engine
This is Rietveld 408576698