Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 2630413002: PlzNavigate: ensure POST navigations are treated as different document (Closed)

Created:
3 years, 11 months ago by clamy
Modified:
3 years, 11 months ago
Reviewers:
Nate Chapin
CC:
chromium-reviews, blink-reviews, loading-reviews_chromium.org, tyoshino+watch_chromium.org, Nate Chapin, gavinp+loader_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

PlzNavigate: ensure POST navigations are treated as different document This CL fixes an issue where the FrameLoader in Blink would attempt to commit a POST navigation as same-site even though a different document navigation should (and has started to) be performed. BUG=608372 Review-Url: https://codereview.chromium.org/2630413002 Cr-Commit-Position: refs/heads/master@{#446011} Committed: https://chromium.googlesource.com/chromium/src/+/62c1bacb7df25e17142f3fd0a56c9a8965cde17d

Patch Set 1 #

Patch Set 2 : PlzNavigate: ensure POST navigations are treated as different document #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -9 lines) Patch
M third_party/WebKit/LayoutTests/FlagExpectations/enable-browser-side-navigation View 1 2 1 chunk +0 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/loader/FrameLoader.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 23 (16 generated)
clamy
@japhet: PTAL
3 years, 11 months ago (2017-01-19 16:45:13 UTC) #11
Nate Chapin
Ok, this is specific to POST navigations that aren't labelled as form submission? LGTM
3 years, 11 months ago (2017-01-23 22:09:53 UTC) #12
clamy
Precisely. Thanks for the review!
3 years, 11 months ago (2017-01-24 15:05:21 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2630413002/40001
3 years, 11 months ago (2017-01-24 15:05:45 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/198926) android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, ...
3 years, 11 months ago (2017-01-24 15:09:07 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2630413002/40001
3 years, 11 months ago (2017-01-25 12:56:51 UTC) #20
commit-bot: I haz the power
3 years, 11 months ago (2017-01-25 13:31:37 UTC) #23
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/62c1bacb7df25e17142f3fd0a56c...

Powered by Google App Engine
This is Rietveld 408576698