[memory-infra] Update docs on memory.top_10_mobile

[memory-infra] Update docs on memory.top_10_mobile

Bugs filed by bisect for memory.top_10_mobile regressions point to this
documentation. Update it so developers trying to diagnose those also
find useful information.

BUG=catapult:#3128

Review-Url: https://codereview.chromium.org/2630403002
Cr-Commit-Position: refs/heads/master@{#444070}
Committed: https://chromium.googlesource.com/chromium/src/+/a247cc78340405414f9ed1085976abc611ab2d1a

[perezju, 2017-01-16 17:07:18]

perezju@chromium.org changed reviewers:
+ primiano@chromium.org

[Primiano Tucci (use gerrit), 2017-01-17 12:15:48]

LGTM with some suggestions, thanks

https://codereview.chromium.org/2630403002/diff/1/docs/memory-infra/memory_be...
File docs/memory-infra/memory_benchmarks.md (right):

https://codereview.chromium.org/2630403002/diff/1/docs/memory-infra/memory_be...
docs/memory-infra/memory_benchmarks.md:192: yet. Therefore, **it's still
important to diagnose and fix regressions
I'd add, after "finalized yet", "and currently they are the reference benchmark
used for the decision making process of the Android release"

https://codereview.chromium.org/2630403002/diff/1/docs/memory-infra/memory_be...
docs/memory-infra/memory_benchmarks.md:197: - load a page on Chrome, wait for it
to load, force garbage collection,
add also "simulate a memory pressure signal" (do I remember correctly?)

https://codereview.chromium.org/2630403002/diff/1/docs/memory-infra/memory_be...
docs/memory-infra/memory_benchmarks.md:215: reproducibility of regressions. If
you are having troubles reproducing a
i'd just be stronger here and say: do not use --story filter when reproducing
this benchmark locally, as doing so affects the results

[perezju, 2017-01-17 16:32:33]

https://codereview.chromium.org/2630403002/diff/1/docs/memory-infra/memory_be...
File docs/memory-infra/memory_benchmarks.md (right):

https://codereview.chromium.org/2630403002/diff/1/docs/memory-infra/memory_be...
docs/memory-infra/memory_benchmarks.md:192: yet. Therefore, **it's still
important to diagnose and fix regressions
On 2017/01/17 12:15:48, Primiano Tucci wrote:
> I'd add, after "finalized yet", "and currently they are the reference
benchmark
> used for the decision making process of the Android release"

Done.

https://codereview.chromium.org/2630403002/diff/1/docs/memory-infra/memory_be...
docs/memory-infra/memory_benchmarks.md:197: - load a page on Chrome, wait for it
to load, force garbage collection,
On 2017/01/17 12:15:48, Primiano Tucci wrote:
> add also "simulate a memory pressure signal" (do I remember correctly?)

No. I added a link to the relevant piece of code. I think we did the "simulate a
memory pressure signal" experiment that one time when we thought it was relevant
to diagnose a particular regression; but the code didn't make it to the
checked-in benchmark.

https://codereview.chromium.org/2630403002/diff/1/docs/memory-infra/memory_be...
docs/memory-infra/memory_benchmarks.md:215: reproducibility of regressions. If
you are having troubles reproducing a
On 2017/01/17 12:15:48, Primiano Tucci wrote:
> i'd just be stronger here and say: do not use --story filter when reproducing
> this benchmark locally, as doing so affects the results

Done. Rephrased this bit.

[perezju, 2017-01-17 16:32:39]

The CQ bit was checked by perezju@chromium.org

[perezju, 2017-01-17 16:32:40]

The patchset sent to the CQ was uploaded after l-g-t-m from
primiano@chromium.org
Link to the patchset: https://codereview.chromium.org/2630403002/#ps20001
(title: "Primiano's comments")

[commit-bot: I haz the power, 2017-01-17 16:32:51]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-17 16:40:54]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484670759697860,
"parent_rev": "33818797373a6eff577677cebd2f659a1328d053", "commit_rev":
"a247cc78340405414f9ed1085976abc611ab2d1a"}

[commit-bot: I haz the power, 2017-01-17 16:41:23]

Description was changed from

==========
[memory-infra] Update docs on memory.top_10_mobile

Bugs filed by bisect for memory.top_10_mobile regressions point to this
documentation. Update it so developers trying to diagnose those also
find useful information.

BUG=catapult:#3128
==========

to

==========
[memory-infra] Update docs on memory.top_10_mobile

Bugs filed by bisect for memory.top_10_mobile regressions point to this
documentation. Update it so developers trying to diagnose those also
find useful information.

BUG=catapult:#3128

Review-Url: https://codereview.chromium.org/2630403002
Cr-Commit-Position: refs/heads/master@{#444070}
Committed:
https://chromium.googlesource.com/chromium/src/+/a247cc78340405414f9ed1085976...
==========

[commit-bot: I haz the power, 2017-01-17 16:41:24]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/a247cc78340405414f9ed1085976...