[collections] Shuffle OrderedHashTable fields around for future optimization

[collections] Shuffle OrderedHashTable fields around for future optimization

A future linear version of the hash table will only need the element count and
deleted element count. Hence moving them to the beginning of the underlying
fixed array makes the transition easier.

BUG=v8:5717
Review-Url: https://codereview.chromium.org/2630373002
Cr-Commit-Position: refs/heads/master@{#42459}
Committed: https://chromium.googlesource.com/v8/v8/+/5f7af3cd0fb099640474872e0796649b3f2a74c5

[Camillo Bruni, 2017-01-16 15:55:31]

The CQ bit was checked by cbruni@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-16 15:55:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Camillo Bruni, 2017-01-16 15:56:28]

cbruni@chromium.org changed reviewers:
+ adamk@chromium.org

[Camillo Bruni, 2017-01-16 15:56:28]

PTAL

[Camillo Bruni, 2017-01-16 15:58:52]

cbruni@chromium.org changed reviewers:
+ jkummerow@chromium.org
- adamk@chromium.org

[Camillo Bruni, 2017-01-16 16:00:52]

Description was changed from

==========
[collections] Shulle OrderedHashTable fields around for future optimization

A future linear version of the hash table will only need the element count and
deleted element count. Hence moving them to the beginning of the underlying
fixed array makes the transition easier.

BUG=v8:5717
==========

to

==========
[collections] Shuffle OrderedHashTable fields around for future optimization

A future linear version of the hash table will only need the element count and
deleted element count. Hence moving them to the beginning of the underlying
fixed array makes the transition easier.

BUG=v8:5717
==========

[commit-bot: I haz the power, 2017-01-16 16:23:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-16 16:23:54]

Dry run: This issue passed the CQ dry run.

[adamk, 2017-01-17 18:28:51]

adamk@chromium.org changed reviewers:
+ adamk@chromium.org

[adamk, 2017-01-17 18:28:52]

lgtm % nit

Ooo, constexprs.

https://codereview.chromium.org/2630373002/diff/1/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/2630373002/diff/1/src/objects.h#newcode4284
src/objects.h:4284: static const int kNextTableIndex = kNumberOfElementsIndex;
Not sure this is any clearer here than it was at the end of the list. At first
glance it looks like a typo.

[Camillo Bruni, 2017-01-18 13:57:36]

The CQ bit was checked by cbruni@chromium.org

[Camillo Bruni, 2017-01-18 13:57:36]

The patchset sent to the CQ was uploaded after l-g-t-m from adamk@chromium.org
Link to the patchset: https://codereview.chromium.org/2630373002/#ps40001
(title: "do the proper english thing")

[commit-bot: I haz the power, 2017-01-18 13:57:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 14:26:58]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1484747856075760,
"parent_rev": "d9adbc0fb23973084f59e9c30c6428ab1bb4af7c", "commit_rev":
"5f7af3cd0fb099640474872e0796649b3f2a74c5"}

[commit-bot: I haz the power, 2017-01-18 14:27:03]

Description was changed from

==========
[collections] Shuffle OrderedHashTable fields around for future optimization

A future linear version of the hash table will only need the element count and
deleted element count. Hence moving them to the beginning of the underlying
fixed array makes the transition easier.

BUG=v8:5717
==========

to

==========
[collections] Shuffle OrderedHashTable fields around for future optimization

A future linear version of the hash table will only need the element count and
deleted element count. Hence moving them to the beginning of the underlying
fixed array makes the transition easier.

BUG=v8:5717

Review-Url: https://codereview.chromium.org/2630373002
Cr-Commit-Position: refs/heads/master@{#42459}
Committed:
https://chromium.googlesource.com/v8/v8/+/5f7af3cd0fb099640474872e0796649b3f2...
==========

[commit-bot: I haz the power, 2017-01-18 14:27:04]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/v8/v8/+/5f7af3cd0fb099640474872e0796649b3f2...

[Camillo Bruni, 2017-01-19 13:57:42]

https://codereview.chromium.org/2630373002/diff/1/src/objects.h
File src/objects.h (right):

https://codereview.chromium.org/2630373002/diff/1/src/objects.h#newcode4284
src/objects.h:4284: static const int kNextTableIndex = kNumberOfElementsIndex;
On 2017/01/17 at 18:28:52, adamk wrote:
> Not sure this is any clearer here than it was at the end of the list. At first
glance it looks like a typo.

humm maybe right :) I'll add a comment to make sure that it's obvious that these
two indices share the same the field.