Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Issue 2630323004: [Devtools] Accessibility pane: correctly show label text source (Closed)

Created:
3 years, 11 months ago by aboxhall
Modified:
3 years, 11 months ago
Reviewers:
dmazzoni, dgozman, samli
CC:
aboxhall, aboxhall+watch_chromium.org, apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, dmazzoni, dmazzoni+watch_chromium.org, dtseng+watch_chromium.org, haraken, je_julie, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, nektar+watch_chromium.org, nektarios, pfeldman+blink_chromium.org, pfeldman, yuzo+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Devtools] Accessibility pane: correctly show label text source Correctly show label text BUG=679526 Review-Url: https://codereview.chromium.org/2630323004 Cr-Commit-Position: refs/heads/master@{#444991} Committed: https://chromium.googlesource.com/chromium/src/+/db535b3763e928b1c4e2f11cd3928dadeba60453

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -23 lines) Patch
M third_party/WebKit/Source/devtools/front_end/accessibility/AccessibilityNodeView.js View 5 chunks +4 lines, -21 lines 0 comments Download
M third_party/WebKit/Source/modules/accessibility/AXNodeObject.cpp View 1 chunk +4 lines, -2 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
aboxhall
3 years, 11 months ago (2017-01-17 05:38:34 UTC) #2
aboxhall
+samli for first look at devtools/front_end
3 years, 11 months ago (2017-01-17 23:29:48 UTC) #4
dmazzoni
lgtm
3 years, 11 months ago (2017-01-17 23:31:42 UTC) #5
samli
lgtm
3 years, 11 months ago (2017-01-18 00:26:21 UTC) #6
aboxhall
dgozman: ptal?
3 years, 11 months ago (2017-01-18 23:44:48 UTC) #7
dgozman
lgtm
3 years, 11 months ago (2017-01-19 23:11:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2630323004/1
3 years, 11 months ago (2017-01-20 04:37:41 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-20 06:04:12 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/db535b3763e928b1c4e2f11cd392...

Powered by Google App Engine
This is Rietveld 408576698