Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(285)

Issue 2630303004: Convert audiolistener-automation-position to testharness (Closed)

Created:
3 years, 11 months ago by Raymond Toy
Modified:
3 years, 11 months ago
Reviewers:
hongchan
CC:
chromium-reviews, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert audiolistener-automation-position to testharness This was converted automatically via for f in `grep -l Audit *.html` do # Replace js-test with testharness and add testharnessreport.js sed -i 's;\(.*\)\(<script.*\)js-test.js\(.*\);\1\2testharness.js\3\ \1\2testharnessreport.js\3 ;' $f # Remove old js-test methods that no longer exist. sed -i '/^[ ]*\(description(.*)\|finishJSTest()\);[ ]*$/d' $f # Remove jsTestIsAsync stuff sed -i '/^[ ]*window.jsTestIsAsync *= *true;[ ]*$/d' $f # Remove expected results file. base=`basename $f .html` git rm $base-expected.txt done BUG=681977 TEST=audiolistener-automation-position.html Review-Url: https://codereview.chromium.org/2630303004 Cr-Commit-Position: refs/heads/master@{#445517} Committed: https://chromium.googlesource.com/chromium/src/+/757919eacf29328fb7e31e95a6833fa989fb1fac

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -33 lines) Patch
M third_party/WebKit/LayoutTests/webaudio/AudioListener/audiolistener-automation-position.html View 4 chunks +2 lines, -12 lines 0 comments Download
D third_party/WebKit/LayoutTests/webaudio/AudioListener/audiolistener-automation-position-expected.txt View 1 chunk +0 lines, -21 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
Raymond Toy
PTAL
3 years, 11 months ago (2017-01-23 20:52:09 UTC) #2
hongchan
lgtm
3 years, 11 months ago (2017-01-23 20:54:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2630303004/1
3 years, 11 months ago (2017-01-23 20:56:09 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-23 22:36:04 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/757919eacf29328fb7e31e95a683...

Powered by Google App Engine
This is Rietveld 408576698