Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: tools/clang/plugins/tests/weak_ptr_factory.txt

Issue 26303002: Make Clang plugin check WeakPtrFactory member order (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Clean up for review Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/clang/plugins/tests/weak_ptr_factory.flags ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/plugins/tests/weak_ptr_factory.txt
diff --git a/tools/clang/plugins/tests/weak_ptr_factory.txt b/tools/clang/plugins/tests/weak_ptr_factory.txt
new file mode 100644
index 0000000000000000000000000000000000000000..f9c2c0a3117516fd6d9164c6e6463a01d31d4089
--- /dev/null
+++ b/tools/clang/plugins/tests/weak_ptr_factory.txt
@@ -0,0 +1,7 @@
+weak_ptr_factory.cpp:35:38: warning: [chromium-style] WeakPtrFactory members which refer to their outer class must be the last member in the outer class definition.
+ base::WeakPtrFactory<FactoryFirst> factory_;
+ ^
+weak_ptr_factory.cpp:41:39: warning: [chromium-style] WeakPtrFactory members which refer to their outer class must be the last member in the outer class definition.
+ base::WeakPtrFactory<FactoryMiddle> factory_;
+ ^
+2 warnings generated.
« no previous file with comments | « tools/clang/plugins/tests/weak_ptr_factory.flags ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698