tools/clang/plugins/tests/weak_ptr_factory.txt - Issue 26303002: Make Clang plugin check WeakPtrFactory member order

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: tools/clang/plugins/tests/weak_ptr_factory.txt

Issue 26303002: Make Clang plugin check WeakPtrFactory member order (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Clean up for review Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 weak_ptr_factory.cpp:35:38: warning: [chromium-style] WeakPtrFactory members whi ch refer to their outer class must be the last member in the outer class definit ion.

	2 base::WeakPtrFactory<FactoryFirst> factory_;

	3 ^

	4 weak_ptr_factory.cpp:41:39: warning: [chromium-style] WeakPtrFactory members whi ch refer to their outer class must be the last member in the outer class definit ion.

	5 base::WeakPtrFactory<FactoryMiddle> factory_;

	6 ^

	7 2 warnings generated.

OLD	NEW

« no previous file with comments | « tools/clang/plugins/tests/weak_ptr_factory.flags ('k') | no next file » | no next file with comments »