Do not allocate SlotAssignment unless a shadowroot has a slot

Do not allocate SlotAssignment unless a ShadowRoot has a slot

Make ShadowRoot::ensureSlotAssignment() private so that it can not be used from 
outside. Now only ShadowRoot has a responsibility in allocating SlotAssignment.

Instead of ShadowRoot::ensureSlotAssignment(), ShadowRoot now provides
public ShadowRoot::slotAssignment(), but it uses DCHECK(m_slotAssignment) so that
it can be used only where we can assume that SlotAssignment is already allocated.

BUG=681134
Review-Url: https://codereview.chromium.org/2630293003
Cr-Commit-Position: refs/heads/master@{#444647}
Committed: https://chromium.googlesource.com/chromium/src/+/db77e9ace4f1948a8d1c87c2bd2de1380526bb5b

[hayato, 2017-01-17 04:04:05]

The CQ bit was checked by hayato@chromium.org

[commit-bot: I haz the power, 2017-01-17 04:04:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-17 04:04:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-17 04:04:16]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[hayato, 2017-01-17 04:11:02]

Description was changed from

==========
Do not allocate SlotAssignment unless a shadowroot has a slot

BUG=681134
==========

to

==========
Do not allocate SlotAssignment unless a ShadowRoot has a slot

Make ShadowRoot::ensureSlotAssignment() private so that it can not be used from 
outside. Now only ShadowRoot has a responsibility in allocating SlotAssignment.

Instead of ShadowRoot::ensureSlotAssignment(), ShadowRoot becomes to provide
ShadowRoot::slotAssignment(), but it uses DCHECK(m_slotAssignment) so that it
can be
used only when we can assert that slotAssignment is already allocated.

BUG=681134
==========

[hayato, 2017-01-17 04:12:33]

Description was changed from

==========
Do not allocate SlotAssignment unless a ShadowRoot has a slot

Make ShadowRoot::ensureSlotAssignment() private so that it can not be used from 
outside. Now only ShadowRoot has a responsibility in allocating SlotAssignment.

Instead of ShadowRoot::ensureSlotAssignment(), ShadowRoot becomes to provide
ShadowRoot::slotAssignment(), but it uses DCHECK(m_slotAssignment) so that it
can be
used only when we can assert that slotAssignment is already allocated.

BUG=681134
==========

to

==========
Do not allocate SlotAssignment unless a ShadowRoot has a slot

Make ShadowRoot::ensureSlotAssignment() private so that it can not be used from 
outside. Now only ShadowRoot has a responsibility in allocating SlotAssignment.

Instead of ShadowRoot::ensureSlotAssignment(), ShadowRoot now provides
public ShadowRoot::slotAssignment(), but it uses DCHECK(m_slotAssignment) so
that
it can be used where we can assert that slotAssignment is already allocated.

BUG=681134
==========

[hayato, 2017-01-17 04:14:07]

Description was changed from

==========
Do not allocate SlotAssignment unless a ShadowRoot has a slot

Make ShadowRoot::ensureSlotAssignment() private so that it can not be used from 
outside. Now only ShadowRoot has a responsibility in allocating SlotAssignment.

Instead of ShadowRoot::ensureSlotAssignment(), ShadowRoot now provides
public ShadowRoot::slotAssignment(), but it uses DCHECK(m_slotAssignment) so
that
it can be used where we can assert that slotAssignment is already allocated.

BUG=681134
==========

to

==========
Do not allocate SlotAssignment unless a ShadowRoot has a slot

Make ShadowRoot::ensureSlotAssignment() private so that it can not be used from 
outside. Now only ShadowRoot has a responsibility in allocating SlotAssignment.

Instead of ShadowRoot::ensureSlotAssignment(), ShadowRoot now provides
public ShadowRoot::slotAssignment(), but it uses DCHECK(m_slotAssignment) so
that
it can be used where we can assume that slotAssignment is already allocated.

BUG=681134
==========

[hayato, 2017-01-17 04:14:46]

hayato@chromium.org changed reviewers:
+ esprehn@chromium.org, kochi@chromium.org

[hayato, 2017-01-17 04:14:46]

PTAL

[hayato, 2017-01-17 04:15:42]

Description was changed from

==========
Do not allocate SlotAssignment unless a ShadowRoot has a slot

Make ShadowRoot::ensureSlotAssignment() private so that it can not be used from 
outside. Now only ShadowRoot has a responsibility in allocating SlotAssignment.

Instead of ShadowRoot::ensureSlotAssignment(), ShadowRoot now provides
public ShadowRoot::slotAssignment(), but it uses DCHECK(m_slotAssignment) so
that
it can be used where we can assume that slotAssignment is already allocated.

BUG=681134
==========

to

==========
Do not allocate SlotAssignment unless a ShadowRoot has a slot

Make ShadowRoot::ensureSlotAssignment() private so that it can not be used from 
outside. Now only ShadowRoot has a responsibility in allocating SlotAssignment.

Instead of ShadowRoot::ensureSlotAssignment(), ShadowRoot now provides
public ShadowRoot::slotAssignment(), but it uses DCHECK(m_slotAssignment) so
that
it can be used only where we can assume that slotAssignment is already
allocated.

BUG=681134
==========

[hayato, 2017-01-17 04:16:03]

Description was changed from

==========
Do not allocate SlotAssignment unless a ShadowRoot has a slot

Make ShadowRoot::ensureSlotAssignment() private so that it can not be used from 
outside. Now only ShadowRoot has a responsibility in allocating SlotAssignment.

Instead of ShadowRoot::ensureSlotAssignment(), ShadowRoot now provides
public ShadowRoot::slotAssignment(), but it uses DCHECK(m_slotAssignment) so
that
it can be used only where we can assume that slotAssignment is already
allocated.

BUG=681134
==========

to

==========
Do not allocate SlotAssignment unless a ShadowRoot has a slot

Make ShadowRoot::ensureSlotAssignment() private so that it can not be used from 
outside. Now only ShadowRoot has a responsibility in allocating SlotAssignment.

Instead of ShadowRoot::ensureSlotAssignment(), ShadowRoot now provides
public ShadowRoot::slotAssignment(), but it uses DCHECK(m_slotAssignment) so
that
it can be used only where we can assume that SlotAssignment is already
allocated.

BUG=681134
==========

[rune, 2017-01-17 10:42:34]

rune@opera.com changed reviewers:
+ rune@opera.com

[rune, 2017-01-17 10:42:34]

lgtm

[esprehn, 2017-01-17 10:48:19]

LGTM w/ nit but you don't have to fix it if you prefer these names.

https://codereview.chromium.org/2630293003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/shadow/ShadowRoot.cpp (right):

https://codereview.chromium.org/2630293003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/shadow/ShadowRoot.cpp:110: void
ShadowRoot::slotAdded(HTMLSlotElement& slot) {
DidAddSlot()

https://codereview.chromium.org/2630293003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/shadow/ShadowRoot.cpp:115: void
ShadowRoot::hostChildSlotNameChanged(const AtomicString& oldValue,
I prefer the did naming.

::DidChangeHostChildSlotName

[kochi, 2017-01-18 01:53:52]

lgtm

[hayato, 2017-01-19 03:12:21]

renamed

[hayato, 2017-01-19 03:12:23]

The CQ bit was checked by hayato@chromium.org

[hayato, 2017-01-19 03:12:23]

The patchset sent to the CQ was uploaded after l-g-t-m from
esprehn@chromium.org, kochi@chromium.org, rune@opera.com
Link to the patchset: https://codereview.chromium.org/2630293003/#ps20001
(title: "renamed")

[commit-bot: I haz the power, 2017-01-19 03:12:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[hayato, 2017-01-19 03:13:50]

Sure. I have renamed these to honer the *did* convention.

https://codereview.chromium.org/2630293003/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/dom/shadow/ShadowRoot.cpp (right):

https://codereview.chromium.org/2630293003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/shadow/ShadowRoot.cpp:110: void
ShadowRoot::slotAdded(HTMLSlotElement& slot) {
On 2017/01/17 at 10:48:18, esprehn wrote:
> DidAddSlot()

Done

https://codereview.chromium.org/2630293003/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/dom/shadow/ShadowRoot.cpp:115: void
ShadowRoot::hostChildSlotNameChanged(const AtomicString& oldValue,
On 2017/01/17 at 10:48:18, esprehn wrote:
> I prefer the did naming.
> 
> ::DidChangeHostChildSlotName

Done

[commit-bot: I haz the power, 2017-01-19 05:00:49]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484795543202190,
"parent_rev": "997841c120ef5c64f5ae10392619a88c0462fedd", "commit_rev":
"db77e9ace4f1948a8d1c87c2bd2de1380526bb5b"}

[commit-bot: I haz the power, 2017-01-19 05:01:22]

Description was changed from

==========
Do not allocate SlotAssignment unless a ShadowRoot has a slot

Make ShadowRoot::ensureSlotAssignment() private so that it can not be used from 
outside. Now only ShadowRoot has a responsibility in allocating SlotAssignment.

Instead of ShadowRoot::ensureSlotAssignment(), ShadowRoot now provides
public ShadowRoot::slotAssignment(), but it uses DCHECK(m_slotAssignment) so
that
it can be used only where we can assume that SlotAssignment is already
allocated.

BUG=681134
==========

to

==========
Do not allocate SlotAssignment unless a ShadowRoot has a slot

Make ShadowRoot::ensureSlotAssignment() private so that it can not be used from 
outside. Now only ShadowRoot has a responsibility in allocating SlotAssignment.

Instead of ShadowRoot::ensureSlotAssignment(), ShadowRoot now provides
public ShadowRoot::slotAssignment(), but it uses DCHECK(m_slotAssignment) so
that
it can be used only where we can assume that SlotAssignment is already
allocated.

BUG=681134

Review-Url: https://codereview.chromium.org/2630293003
Cr-Commit-Position: refs/heads/master@{#444647}
Committed:
https://chromium.googlesource.com/chromium/src/+/db77e9ace4f1948a8d1c87c2bd2d...
==========

[commit-bot: I haz the power, 2017-01-19 05:01:24]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/db77e9ace4f1948a8d1c87c2bd2d...