Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(673)

Issue 2630293002: [wasm] Remove special treatment of F(32|64)Sub in the interpreter. (Closed)

Created:
3 years, 11 months ago by ahaas
Modified:
3 years, 11 months ago
Reviewers:
titzer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] Remove special treatment of F(32|64)Sub in the interpreter. The special treatment is not required anymore because the wasm spec changed and NaNs do not have to be preserved anymore. In addition, it may introduce non-determinism which confused the fuzzers. R=titzer@chromium.org BUG=chromium:681033 Review-Url: https://codereview.chromium.org/2630293002 Cr-Commit-Position: refs/heads/master@{#42359} Committed: https://chromium.googlesource.com/v8/v8/+/fec614151a3f5aad0a6d44d7eafc38e8f3a006c2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -48 lines) Patch
M src/wasm/wasm-interpreter.cc View 5 chunks +2 lines, -48 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
ahaas
3 years, 11 months ago (2017-01-16 10:15:25 UTC) #1
titzer
LGTM, nice to get rid of that mess.
3 years, 11 months ago (2017-01-16 10:22:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2630293002/1
3 years, 11 months ago (2017-01-16 10:41:28 UTC) #8
commit-bot: I haz the power
3 years, 11 months ago (2017-01-16 10:43:08 UTC) #11
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/v8/v8/+/fec614151a3f5aad0a6d44d7eafc38e8f3a...

Powered by Google App Engine
This is Rietveld 408576698