Force usage of HTTPS for Google services.

Force usage of HTTPS for Google services.

This is effectively a revert of http://crrev.com/136205 , switching back to
searchdomaincheck "format=domain" from "format=url", but this time using HTTPS
instead of HTTP. Note that in general this should have no visible effect, since
for Chrome 25+ searchdomaincheck is supposed to be sending "https..." URLs
anyway. The only difference is that, if searchdomaincheck is never accessed,
the "out of the box" default value for the Google homepage switches from
"http://www.google.com/" to "https://www.google.com/".

This shouldn't cause any additional bustage to existing users, since Google
search over HTTP will just redirect to HTTPS anyway, so anyone whose network
doesn't support HTTPS accesses is already seeing broken behavior. (For the same
reason, this means even the "out of the box default" change noted above
shouldn't really be visible to end users.)

It's still possible for users to "downgrade" Google searches to HTTP using the
nosslsearch mechanism, but that's not in scope for Chrome to address.

BUG=364183
TEST=none
TBR=isherman

Committed: https://crrev.com/2d834f820e54622dee26019b27f204f34392ece7
Cr-Commit-Position: refs/heads/master@{#314721}

[Peter Kasting, 2014-05-02 23:16:24]

An unchanged copy of most of https://codereview.chromium.org/256423004/ .  After
https://codereview.chromium.org/263823007/ and
https://codereview.chromium.org/269723007/ land, I'll run this through the
trybots again to see if things look better.

[nednguyen, 2014-05-14 00:39:07]

The CQ bit was checked by nednguyen@google.com

[commit-bot: I haz the power, 2014-05-14 00:39:36]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/pkasting@chromium.org/263023002/20001

[Peter Kasting, 2014-05-14 00:43:53]

The CQ bit was unchecked by pkasting@chromium.org

[Ilya Sherman, 2014-09-20 00:59:31]

Sorry, I seem to have missed this review request months ago.  Is this CL still
relevant?

[Peter Kasting, 2014-09-20 01:00:51]

On 2014/09/20 00:59:31, Ilya Sherman wrote:
> Sorry, I seem to have missed this review request months ago.  Is this CL still
> relevant?

This CL is currently blocked.

[nednguyen, 2014-11-15 02:47:37]

On 2014/09/20 01:00:51, Peter Kasting wrote:
> On 2014/09/20 00:59:31, Ilya Sherman wrote:
> > Sorry, I seem to have missed this review request months ago.  Is this CL
still
> > relevant?
> 
> This CL is currently blocked.

It looks like telemetry_test & perf_test are all passing now. Do you want to try
this again?

[Peter Kasting, 2014-11-15 03:12:56]

On 2014/11/15 02:47:37, nednguyen wrote:
> On 2014/09/20 01:00:51, Peter Kasting wrote:
> > On 2014/09/20 00:59:31, Ilya Sherman wrote:
> > > Sorry, I seem to have missed this review request months ago.  Is this CL
> still
> > > relevant?
> > 
> > This CL is currently blocked.
> 
> It looks like telemetry_test & perf_test are all passing now. Do you want to
try
> this again?

The CL isn't unblocked yet.  I was intending to try it again when it was.

[Peter Kasting, 2015-02-04 20:04:11]

OK, this is finally ready for review, as all the blockers have been addressed.

[Ilya Sherman, 2015-02-05 00:44:50]

LGTM, thanks.

https://codereview.chromium.org/263023002/diff/180001/components/google/core/...
File components/google/core/browser/google_url_tracker_unittest.cc (right):

https://codereview.chromium.org/263023002/diff/180001/components/google/core/...
components/google/core/browser/google_url_tracker_unittest.cc:254:
MockSearchDomainCheckResponse(".google.evil.com");
Please add a test case for a full URL, i.e. "https://www.google.com".  That
would be the complement to the test you're replacing, I think.

[Peter Kasting, 2015-02-05 01:14:41]

New patchsets have been uploaded after l-g-t-m from isherman@chromium.org

[Peter Kasting, 2015-02-05 01:14:47]

The CQ bit was checked by pkasting@chromium.org

[commit-bot: I haz the power, 2015-02-05 01:15:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/263023002/200001

[commit-bot: I haz the power, 2015-02-05 02:20:24]

Committed patchset #11 (id:200001)

[commit-bot: I haz the power, 2015-02-05 02:21:46]

Patchset 11 (id:??) landed as
https://crrev.com/2d834f820e54622dee26019b27f204f34392ece7
Cr-Commit-Position: refs/heads/master@{#314721}

[deanj, 2015-02-05 03:07:07]

On 2015/02/04 20:04:11, Peter Kasting wrote:
> OK, this is finally ready for review, as all the blockers have been addressed.

FYI, related to the description of the change; nosslsearch has been deprecated,
and will be removed in 2015.

[Mathieu, 2015-02-13 14:07:49]

A revert of this CL (patchset #11 id:200001) has been created in
https://codereview.chromium.org/922223002/ by mathp@chromium.org.

The reason for reverting is: Testing as potential cause of crbug.com/456681.