Force usage of HTTPS for Google services.

Force usage of HTTPS for Google services.

This is effectively a revert of http://crrev.com/136205 , switching back to
searchdomaincheck "format=domain" from "format=url", but this time using HTTPS
instead of HTTP.  Note that in general this should have no visible effect, since
for Chrome 25+ searchdomaincheck is supposed to be sending "https..." URLs
anyway.  The only difference is that, if searchdomaincheck is never accessed,
the "out of the box" default value for the Google homepage switches from
"http://www.google.com/" to "https://www.google.com/".

This shouldn't cause any additional bustage to existing users, since Google
search over HTTP will just redirect to HTTPS anyway, so anyone whose network
doesn't support HTTPS accesses is already seeing broken behavior.  (For the same
reason, this means even the "out of the box default" change noted above
shouldn't really be visible to end users.)

It's still possible for users to "downgrade" Google searches to HTTP using the
nosslsearch mechanism, but that's not in scope for Chrome to address.

BUG=364183
TEST=none
R=isherman@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267900

[Peter Kasting, 2014-04-24 02:26:00]

This change is the outcome of some pretty extensive discussion; if you're bored,
feel free to read internal bug 13288104 (though I recommend against it).

[Ilya Sherman, 2014-04-24 06:39:45]

LGTM

https://codereview.chromium.org/256423004/diff/1/chrome/browser/google/google...
File chrome/browser/google/google_url_tracker.cc (right):

https://codereview.chromium.org/256423004/diff/1/chrome/browser/google/google...
chrome/browser/google/google_url_tracker.cc:155: (fetched_google_url_ ==
last_prompted_url)) {
nit: I'd prefer that you align the two "fetched_google_url_"s.

[Peter Kasting, 2014-04-24 21:32:05]

Landing if I get good tryjobs.

https://codereview.chromium.org/256423004/diff/1/chrome/browser/google/google...
File chrome/browser/google/google_url_tracker.cc (right):

https://codereview.chromium.org/256423004/diff/1/chrome/browser/google/google...
chrome/browser/google/google_url_tracker.cc:155: (fetched_google_url_ ==
last_prompted_url)) {
On 2014/04/24 06:39:45, Ilya Sherman wrote:
> nit: I'd prefer that you align the two "fetched_google_url_"s.

Done.

[Peter Kasting, 2014-05-02 19:10:25]

Manually committing despite telemetry failures per
https://code.google.com/p/chromium/issues/detail?id=367306#c4 ; if the main tree
turns red, I'll disable the tests in question.

[Peter Kasting, 2014-05-02 19:46:49]

Committed patchset #3 manually as r267900 (presubmit successful).

[Peter Kasting, 2014-05-02 23:03:50]

This was reverted; I will open a new CL for the reland attempt.