Return AltGraph for right-Alt keydown/keyup, under layouts which use AltGraph.

Return AltGraph for right-Alt keydown/keyup, under layouts which use AltGraph.

W3C UI Events defines the "AltGraph" value for KeyboardEvent.key, to express the meaning of the right-Alt key (i.e. KeyboardEvent.code=AltRight) under layouts which use ISO Level 3 Shift to generate some characters (e.g. en-UK, fr-FR, etc).

This patch fixes Chrome to generate AltGraph under such layouts, where previously it would have generated events with key=Alt.

BUG=681363
Review-Url: https://codereview.chromium.org/2630213003
Cr-Commit-Position: refs/heads/master@{#444516}
Committed: https://chromium.googlesource.com/chromium/src/+/22d68c2c24b7c8a4d65802d2b385d09d50e575c9

[Wez, 2017-01-16 08:27:42]

The CQ bit was checked by wez@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-16 08:27:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-16 09:19:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-16 09:19:43]

Dry run: This issue passed the CQ dry run.

[Wez, 2017-01-17 03:30:10]

wez@chromium.org changed reviewers:
+ chongz@chromium.org, garykac@chromium.org

[Wez, 2017-01-17 03:30:11]

chongz: Please review the PlatformKeyMap changes.
garykac: This fixes Chrome to generate keydown/keyup AltGraph events on Windows,
to match the spec, though the spec differs from what e.g. Edge currently
implements. WDYT?

[chongz, 2017-01-17 15:29:46]

On 2017/01/17 03:30:11, Wez wrote:
> chongz: Please review the PlatformKeyMap changes.

Thanks for the patch! PlatformKeyMap changes LGTM assuming ALT &
EF_IS_EXTENDED_KEY => ALT_GRAPH.

Just to confirm: After CL, pressing right Alt on fr layout (us keyboard) will
generate Ctrl and AltGr keydown/up (instead of Ctrl and Alt keydown/up).

> garykac: This fixes Chrome to generate keydown/keyup AltGraph events on
Windows,
> to match the spec, though the spec differs from what e.g. Edge currently
> implements. WDYT?

Will wait for garykac@'s confirmation.

[Wez, 2017-01-17 18:16:27]

On 2017/01/17 15:29:46, chongz wrote:
> On 2017/01/17 03:30:11, Wez wrote:
> > chongz: Please review the PlatformKeyMap changes.
> 
> Thanks for the patch! PlatformKeyMap changes LGTM assuming ALT &
> EF_IS_EXTENDED_KEY => ALT_GRAPH.

Alt + EF_IS_EXTENDED_KEY means right-Alt, which is the key Windows uses for
AltGraph, yes.

> Just to confirm: After CL, pressing right Alt on fr layout (us keyboard) will
> generate Ctrl and AltGr keydown/up (instead of Ctrl and Alt keydown/up).

Yes; this CL just changes the second keydown/keyup from key=Alt to key=AltGraph.

Fixing the event sequence is a separate issue; I'm writing up some notes now on
options to address that.

> > garykac: This fixes Chrome to generate keydown/keyup AltGraph events on
> Windows,
> > to match the spec, though the spec differs from what e.g. Edge currently
> > implements. WDYT?
> 
> Will wait for garykac@'s confirmation.

Spoke to garykac@ just now; I gather that Edge's implementation is basically
identical to IE11, which implements a slightly older version of DOM3 UI Events.
That implementation has a couple of other bugs, e.g. AltGraph+3 under a FR/FR
layout generates keypress='#' but keydown/keyup with key='3', interestingly.

[garykac, 2017-01-18 15:55:29]

lgtm

https://codereview.chromium.org/2630213003/diff/1/ui/events/keycodes/platform...
File ui/events/keycodes/platform_key_map_win.cc (right):

https://codereview.chromium.org/2630213003/diff/1/ui/events/keycodes/platform...
ui/events/keycodes/platform_key_map_win.cc:290: if (key == DomKey::ALT && (flags
& EF_IS_EXTENDED_KEY) && has_alt_graph_) {
Could you add a brief comment above this line?

[Wez, 2017-01-18 21:06:15]

Description was changed from

==========
Return AltGraph rather than Alt under affected layouts

BUG=
==========

to

==========
Return AltGraph for right-Alt keydown/keyup, under layouts which use AltGraph.

W3C UI Events defines the "AltGraph" value for KeyboardEvent.key, to express the
meaning of the right-Alt key (i.e. KeyboardEvent.code=AltRight) under layouts
which use ISO Level 3 Shift to generate some characters (e.g. en-UK, fr-FR,
etc).

This patch fixes Chrome to generate AltGraph under such layouts, where
previously it would have generated events with key=Alt.

BUG=681363
==========

[Wez, 2017-01-18 21:36:35]

FYI

https://codereview.chromium.org/2630213003/diff/1/ui/events/keycodes/platform...
File ui/events/keycodes/platform_key_map_win.cc (right):

https://codereview.chromium.org/2630213003/diff/1/ui/events/keycodes/platform...
ui/events/keycodes/platform_key_map_win.cc:290: if (key == DomKey::ALT && (flags
& EF_IS_EXTENDED_KEY) && has_alt_graph_) {
On 2017/01/18 15:55:29, garykac wrote:
> Could you add a brief comment above this line?

Done.

[Wez, 2017-01-18 21:36:39]

The CQ bit was checked by wez@chromium.org

[Wez, 2017-01-18 21:36:39]

The patchset sent to the CQ was uploaded after l-g-t-m from chongz@chromium.org,
garykac@chromium.org
Link to the patchset: https://codereview.chromium.org/2630213003/#ps20001
(title: "Add comment")

[commit-bot: I haz the power, 2017-01-18 21:37:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 22:34:21]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484775399260260,
"parent_rev": "83e3fd52a0a04d510a1476899646470724feb53a", "commit_rev":
"22d68c2c24b7c8a4d65802d2b385d09d50e575c9"}

[commit-bot: I haz the power, 2017-01-18 22:34:51]

Description was changed from

==========
Return AltGraph for right-Alt keydown/keyup, under layouts which use AltGraph.

W3C UI Events defines the "AltGraph" value for KeyboardEvent.key, to express the
meaning of the right-Alt key (i.e. KeyboardEvent.code=AltRight) under layouts
which use ISO Level 3 Shift to generate some characters (e.g. en-UK, fr-FR,
etc).

This patch fixes Chrome to generate AltGraph under such layouts, where
previously it would have generated events with key=Alt.

BUG=681363
==========

to

==========
Return AltGraph for right-Alt keydown/keyup, under layouts which use AltGraph.

W3C UI Events defines the "AltGraph" value for KeyboardEvent.key, to express the
meaning of the right-Alt key (i.e. KeyboardEvent.code=AltRight) under layouts
which use ISO Level 3 Shift to generate some characters (e.g. en-UK, fr-FR,
etc).

This patch fixes Chrome to generate AltGraph under such layouts, where
previously it would have generated events with key=Alt.

BUG=681363

Review-Url: https://codereview.chromium.org/2630213003
Cr-Commit-Position: refs/heads/master@{#444516}
Committed:
https://chromium.googlesource.com/chromium/src/+/22d68c2c24b7c8a4d65802d2b385...
==========

[commit-bot: I haz the power, 2017-01-18 22:34:52]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/22d68c2c24b7c8a4d65802d2b385...