Issue 2630193002: [tools/chrome_proxy] Update inspector_network data collecting code to trace_data.AddTraceFor

Issue 2630193002: [tools/chrome_proxy] Update inspector_network data collecting code to trace_data.AddTraceFor (Closed)

Created:
3 years, 11 months ago by nednguyen

Modified:
3 years, 11 months ago

Reviewers:
bustamante

CC:
chromium-reviews, tbansal+watch-data-reduction-proxy_chromium.org

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

[tools/chrome_proxy] Update inspector_network data collecting code to trace_data.AddTraceFor The API trace_data.AddEventsTo is replaced by trace_data.AddTraceFor in https://codereview.chromium.org/2619073002/ BUG=catapult:#3119 TBR=bustamante@chromium.org Review-Url: https://codereview.chromium.org/2630193002 Cr-Commit-Position: refs/heads/master@{#443817} Committed: https://chromium.googlesource.com/chromium/src/+/95ff5a1ca82f47cc4aafb1a0d3ea97445fb2e64a

Created: 3 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	tools/chrome_proxy/common/inspector_network.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 10 (5 generated)

nednguyen

On 2017/01/15 16:57:35, nednguyen wrote: Verified that ./run_tests --browser=system inspector_network_unittest is passing with this, so ...

3 years, 11 months ago (2017-01-15 16:58:13 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2630193002/1

3 years, 11 months ago (2017-01-15 16:58:39 UTC) #6

commit-bot: I haz the power

Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/95ff5a1ca82f47cc4aafb1a0d3ea97445fb2e64a

3 years, 11 months ago (2017-01-15 17:08:20 UTC) #9

Message was sent while issue was closed.

lgtm thanks!