Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Issue 2630103002: Add --windows10-custom-titlebar to the about:flags page. (Closed)

Created:
3 years, 11 months ago by Bret
Modified:
3 years, 10 months ago
Reviewers:
Peter Kasting, Mark P
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add --windows10-custom-titlebar to the about:flags page. TBR=grt@chromium.org BUG=505013 Review-Url: https://codereview.chromium.org/2630103002 Cr-Commit-Position: refs/heads/master@{#446880} Committed: https://chromium.googlesource.com/chromium/src/+/7f89cc52e9299192015ccaf375f15e72d5da2dd1

Patch Set 1 #

Patch Set 2 : add flag to histograms #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -0 lines) Patch
M chrome/app/generated_resources.grd View 1 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/browser/about_flags.cc View 1 1 chunk +7 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 21 (13 generated)
Bret
grt@ to TBR for generated_resources.grd OWNERS
3 years, 11 months ago (2017-01-15 02:11:34 UTC) #3
Peter Kasting
LGTM
3 years, 11 months ago (2017-01-17 20:41:00 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2630103002/1
3 years, 11 months ago (2017-01-17 22:47:34 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/365517)
3 years, 11 months ago (2017-01-18 00:46:19 UTC) #8
Bret
mpearson@: histograms.xml OWNERS
3 years, 11 months ago (2017-01-26 00:27:36 UTC) #10
Mark P
histograms.xml lgtm
3 years, 11 months ago (2017-01-26 05:03:32 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2630103002/20001
3 years, 10 months ago (2017-01-28 00:35:17 UTC) #18
commit-bot: I haz the power
3 years, 10 months ago (2017-01-28 02:05:06 UTC) #21
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/7f89cc52e9299192015ccaf375f1...

Powered by Google App Engine
This is Rietveld 408576698