Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(79)

Issue 2630023002: Do not fetch tokens for telemetry tests. (Closed)

Created:
3 years, 11 months ago by achuithb
Modified:
3 years, 11 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, oshima+watch_chromium.org, davemoore+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Do not fetch tokens for telemetry tests. Time reduced for each telemetry login from 22 sec to 8 sec. BUG=chromium:638131 TEST=manual. Review-Url: https://codereview.chromium.org/2630023002 Cr-Commit-Position: refs/heads/master@{#443763} Committed: https://chromium.googlesource.com/chromium/src/+/db3849840dea3dae2de134d875423ad05aa27f78

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -0 lines) Patch
M chrome/browser/chromeos/policy/policy_oauth2_token_fetcher.cc View 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (8 generated)
achuithb
Xiyuan, could you PTAL?
3 years, 11 months ago (2017-01-13 23:36:08 UTC) #3
xiyuan
lgtm
3 years, 11 months ago (2017-01-13 23:43:41 UTC) #5
achuithb
On 2017/01/13 23:43:41, xiyuan wrote: > lgtm ty!
3 years, 11 months ago (2017-01-14 01:34:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2630023002/1
3 years, 11 months ago (2017-01-14 01:35:00 UTC) #10
commit-bot: I haz the power
3 years, 11 months ago (2017-01-14 01:41:41 UTC) #13
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/db3849840dea3dae2de134d87542...

Powered by Google App Engine
This is Rietveld 408576698