Support control clipping for PaintLayers.

Support control clipping for PaintLayers.

Now such clips behave like other overflow clips.

BUG=671864
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2629983003
Cr-Commit-Position: refs/heads/master@{#444532}
Committed: https://chromium.googlesource.com/chromium/src/+/b54db9226dbbd130ba7ea0aac6125aca81a18020

[chrishtr, 2017-01-13 22:21:55]

Description was changed from

==========
none


none


none


none


none

BUG=
==========

to

==========
none


none


none


none


none

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2017-01-13 22:22:52]

Description was changed from

==========
none


none


none


none


none

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Support control clipping for PaintLayers.

Now such clips behave like other overflow clips.

BUG=671864
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

[chrishtr, 2017-01-13 22:23:15]

chrishtr@chromium.org changed reviewers:
+ pdr@chromium.org

[chrishtr, 2017-01-13 22:59:48]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-13 23:00:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 23:45:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-13 23:45:46]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[pdr., 2017-01-14 00:41:23]

On 2017/01/13 at 22:23:16, chrishtr wrote:
> 

LGTM if it's just that assert that needs updating.

[chrishtr, 2017-01-14 01:05:04]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-14 01:05:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-14 02:47:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-14 02:47:49]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[chrishtr, 2017-01-16 18:34:37]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-16 18:35:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-16 19:55:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-16 19:55:08]

Dry run: Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[chrishtr, 2017-01-17 03:51:04]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-17 03:51:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-17 05:31:11]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-17 05:31:11]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[chrishtr, 2017-01-17 15:52:49]

PTAL. I added a unittest to PaintLayerClipperTest and cleaned up the code
slightly.
I tried automatic rebaseline, but three times in a row it failed on Android
(will follow
up).

[pdr., 2017-01-17 18:13:59]

On 2017/01/17 at 15:52:49, chrishtr wrote:
> PTAL. I added a unittest to PaintLayerClipperTest and cleaned up the code
slightly.
> I tried automatic rebaseline, but three times in a row it failed on Android
(will follow
> up).

LGTM

[chrishtr, 2017-01-17 21:44:42]

The CQ bit was checked by chrishtr@chromium.org

[commit-bot: I haz the power, 2017-01-17 21:45:17]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-17 23:59:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-17 23:59:35]

Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[chrishtr, 2017-01-18 00:13:50]

The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-18 00:14:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 00:53:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-18 00:53:57]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[chrishtr, 2017-01-18 21:12:29]

The CQ bit was checked by chrishtr@chromium.org

[chrishtr, 2017-01-18 21:12:30]

https://codereview.chromium.org/2629983003/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/core/paint/PaintLayerClipperTest.cpp (right):

https://codereview.chromium.org/2629983003/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/paint/PaintLayerClipperTest.cpp:87: #if
OS(MACOSX)
Added OSX-specific expectations. I tried to make mac use the
default mock theme, but it was not easy due to how the compilation is
set up.

https://codereview.chromium.org/2629983003/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/core/paint/PaintLayerClipperTest.cpp:90:
EXPECT_EQ(LayoutRect(3, 4, 210, 28), backgroundRect.rect());
On Mac, input elements are forced into not being more than a certain
height.

[chrishtr, 2017-01-18 21:12:30]

The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org
Link to the patchset: https://codereview.chromium.org/2629983003/#ps120001
(title: "none")

[commit-bot: I haz the power, 2017-01-18 21:12:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-18 23:07:24]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1484773949588060,
"parent_rev": "68a9f80c98b83971e4d5a189726b97cc79573ad5", "commit_rev":
"b54db9226dbbd130ba7ea0aac6125aca81a18020"}

[commit-bot: I haz the power, 2017-01-18 23:07:57]

Description was changed from

==========
Support control clipping for PaintLayers.

Now such clips behave like other overflow clips.

BUG=671864
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
==========

to

==========
Support control clipping for PaintLayers.

Now such clips behave like other overflow clips.

BUG=671864
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2629983003
Cr-Commit-Position: refs/heads/master@{#444532}
Committed:
https://chromium.googlesource.com/chromium/src/+/b54db9226dbbd130ba7ea0aac612...
==========

[commit-bot: I haz the power, 2017-01-18 23:07:59]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/b54db9226dbbd130ba7ea0aac612...