Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(998)

Issue 2629923003: Complete usage tracking for OffscreenCanvas.convertToBlob API (Closed)

Created:
3 years, 11 months ago by xlai (Olivia)
Modified:
3 years, 11 months ago
Reviewers:
jwd, Justin Novosad
CC:
chromium-reviews, dshwang, ajuma+watch-canvas_chromium.org, blink-reviews-html_chromium.org, dglazkov+blink, Rik, asvitkine+watch_chromium.org, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Complete usage tracking for OffscreenCanvas.convertToBlob API We've decided to merge the usage data from OffscreenCanvas.convertToBlob to canvas.toBlob because they share the same logic in CanvasAsyncBlobCreator. Moreover, previously we forgot to add a new histogram 'Canvas.RequestedImageMimeTypes_convertToBlobPromise' which is recorded in ImageEncoderUtils::toEncodingMimeType; so in this CL I'm adding it. BUG=653599 Review-Url: https://codereview.chromium.org/2629923003 Cr-Commit-Position: refs/heads/master@{#443957} Committed: https://chromium.googlesource.com/chromium/src/+/9c7d5f102a02c3cb9e740deab5032c8c27a3a5c6

Patch Set 1 #

Total comments: 3

Patch Set 2 : fix based on comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -37 lines) Patch
M third_party/WebKit/Source/core/html/canvas/CanvasAsyncBlobCreator.cpp View 8 chunks +36 lines, -36 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 4 chunks +25 lines, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
xlai (Olivia)
3 years, 11 months ago (2017-01-13 20:01:16 UTC) #2
Justin Novosad
https://codereview.chromium.org/2629923003/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2629923003/diff/1/tools/metrics/histograms/histograms.xml#newcode109636 tools/metrics/histograms/histograms.xml:109636: + <suffix name="convertToBlobPromise" I don't see where this suffix ...
3 years, 11 months ago (2017-01-13 20:09:54 UTC) #3
xlai (Olivia)
https://codereview.chromium.org/2629923003/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2629923003/diff/1/tools/metrics/histograms/histograms.xml#newcode109636 tools/metrics/histograms/histograms.xml:109636: + <suffix name="convertToBlobPromise" On 2017/01/13 20:09:54, Justin Novosad wrote: ...
3 years, 11 months ago (2017-01-13 20:13:11 UTC) #4
Justin Novosad
Ah! lgtm
3 years, 11 months ago (2017-01-13 22:20:48 UTC) #5
jwd
LGTM with nit. https://codereview.chromium.org/2629923003/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/2629923003/diff/1/tools/metrics/histograms/histograms.xml#newcode4215 tools/metrics/histograms/histograms.xml:4215: + also gathered into this histogram, ...
3 years, 11 months ago (2017-01-16 21:03:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2629923003/20001
3 years, 11 months ago (2017-01-16 21:40:02 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-16 23:16:31 UTC) #12
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9c7d5f102a02c3cb9e740deab503...

Powered by Google App Engine
This is Rietveld 408576698