Complete usage tracking for OffscreenCanvas.convertToBlob API

Complete usage tracking for OffscreenCanvas.convertToBlob API

We've decided to merge the usage data from OffscreenCanvas.convertToBlob to
canvas.toBlob because they share the same logic in CanvasAsyncBlobCreator.
Moreover, previously we forgot to add a new histogram
'Canvas.RequestedImageMimeTypes_convertToBlobPromise' which is recorded in
ImageEncoderUtils::toEncodingMimeType; so in this CL I'm adding it.

BUG=653599
Review-Url: https://codereview.chromium.org/2629923003
Cr-Commit-Position: refs/heads/master@{#443957}
Committed: https://chromium.googlesource.com/chromium/src/+/9c7d5f102a02c3cb9e740deab5032c8c27a3a5c6

[xlai (Olivia), 2017-01-13 20:01:16]

xlai@chromium.org changed reviewers:
+ junov@chromium.org, jwd@chromium.org

[Justin Novosad, 2017-01-13 20:09:54]

https://codereview.chromium.org/2629923003/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2629923003/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:109636: +  <suffix
name="convertToBlobPromise"
I don't see where this suffix is referenced.

[xlai (Olivia), 2017-01-13 20:13:11]

https://codereview.chromium.org/2629923003/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2629923003/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:109636: +  <suffix
name="convertToBlobPromise"
On 2017/01/13 20:09:54, Justin Novosad wrote:
> I don't see where this suffix is referenced.

It's actually here:
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/platform/image...

This is a function which records the image usage types for toDataURL, toBlob,
convertToBlob. I was checking up the usage data for convertToBlob today and
realize
that the histogram suffix is not present at all because the previous CL forgot 
to add one.

[Justin Novosad, 2017-01-13 22:20:48]

Ah!  lgtm

[jwd, 2017-01-16 21:03:07]

LGTM with nit.

https://codereview.chromium.org/2629923003/diff/1/tools/metrics/histograms/hi...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2629923003/diff/1/tools/metrics/histograms/hi...
tools/metrics/histograms/histograms.xml:4215: +    also gathered into this
histogram, because the logic flow is exactly same as
Nit: "is exactly the same as..." for all summaries.

[xlai (Olivia), 2017-01-16 21:39:50]

The CQ bit was checked by xlai@chromium.org

[xlai (Olivia), 2017-01-16 21:39:50]

The patchset sent to the CQ was uploaded after l-g-t-m from jwd@chromium.org,
junov@chromium.org
Link to the patchset: https://codereview.chromium.org/2629923003/#ps20001
(title: "fix based on comment")

[commit-bot: I haz the power, 2017-01-16 21:40:02]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-16 23:16:00]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484602790111700,
"parent_rev": "f2b6b4c6b17f90d48d986c3856f4a422ddbdbc2c", "commit_rev":
"9c7d5f102a02c3cb9e740deab5032c8c27a3a5c6"}

[commit-bot: I haz the power, 2017-01-16 23:16:31]

Description was changed from

==========
Complete usage tracking for OffscreenCanvas.convertToBlob API

We've decided to merge the usage data from OffscreenCanvas.convertToBlob to
canvas.toBlob because they share the same logic in CanvasAsyncBlobCreator.
Moreover, previously we forgot to add a new histogram
'Canvas.RequestedImageMimeTypes_convertToBlobPromise' which is recorded in
ImageEncoderUtils::toEncodingMimeType; so in this CL I'm adding it.

BUG=653599
==========

to

==========
Complete usage tracking for OffscreenCanvas.convertToBlob API

We've decided to merge the usage data from OffscreenCanvas.convertToBlob to
canvas.toBlob because they share the same logic in CanvasAsyncBlobCreator.
Moreover, previously we forgot to add a new histogram
'Canvas.RequestedImageMimeTypes_convertToBlobPromise' which is recorded in
ImageEncoderUtils::toEncodingMimeType; so in this CL I'm adding it.

BUG=653599

Review-Url: https://codereview.chromium.org/2629923003
Cr-Commit-Position: refs/heads/master@{#443957}
Committed:
https://chromium.googlesource.com/chromium/src/+/9c7d5f102a02c3cb9e740deab503...
==========

[commit-bot: I haz the power, 2017-01-16 23:16:31]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9c7d5f102a02c3cb9e740deab503...