Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 2629883005: Adding metrics on the usefulness of the Win10 version of the Welcome Page (Closed)

Created:
3 years, 11 months ago by tmartino
Modified:
3 years, 11 months ago
Reviewers:
Mathieu
CC:
chromium-reviews
Target Ref:
refs/pending/branch-heads/2924
Project:
chromium
Visibility:
Public.

Description

Adding metrics on the usefulness of the Win10 version of the Welcome Page Records an histogram value that indicates if the instructions helped the user change their default browser and/or pin Chrome to the taskbar. BUG=648686 NOTRY=true NOPRESUBMIT=true Review-Url: https://codereview.chromium.org/2513953004 Cr-Commit-Position: refs/heads/master@{#434550} (cherry picked from commit 444ce88afe130945dae057125d706b789da9282d) Review-Url: https://codereview.chromium.org/2629883005 Cr-Commit-Position: refs/branch-heads/2924@{#764} Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059} Committed: https://chromium.googlesource.com/chromium/src/+/511870edeca2bb6b9b2adf04836a017e7569cdc6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -11 lines) Patch
M chrome/browser/ui/webui/welcome_win10_handler.h View 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/ui/webui/welcome_win10_handler.cc View 5 chunks +56 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/welcome_win10_ui.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M tools/metrics/actions/actions.xml View 1 chunk +8 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 3 chunks +34 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2629883005/1
3 years, 11 months ago (2017-01-13 21:23:51 UTC) #3
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
3 years, 11 months ago (2017-01-13 21:23:53 UTC) #5
Mathieu
merge lgtm!
3 years, 11 months ago (2017-01-13 21:46:13 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2629883005/1
3 years, 11 months ago (2017-01-13 21:48:01 UTC) #9
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 21:51:46 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/511870edeca2bb6b9b2adf04836a...

Powered by Google App Engine
This is Rietveld 408576698