Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(429)

Issue 2629853003: Update the Share Extension View (Closed)

Created:
3 years, 11 months ago by gambard
Modified:
3 years, 11 months ago
Reviewers:
Olivier
CC:
chromium-reviews, extensions-reviews_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, marq+watch_chromium.org, chromium-apps-reviews_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Update the Share Extension View This CL updates the ShareExtensionView, allowing the URL to be displayed on 3 lines and changes the animation of the screenshot view to have it expanding from the right instead of sliding in from the left. BUG=680912 Review-Url: https://codereview.chromium.org/2629853003 Cr-Commit-Position: refs/heads/master@{#443540} Committed: https://chromium.googlesource.com/chromium/src/+/71db1d97d86d4bfa89edb4d8b7bbebdecf701b47

Patch Set 1 #

Patch Set 2 : Cleanup #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -54 lines) Patch
M ios/chrome/share_extension/share_extension_view.mm View 1 5 chunks +68 lines, -54 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
gambard
PTAL.
3 years, 11 months ago (2017-01-13 11:46:11 UTC) #2
Olivier
lgtm
3 years, 11 months ago (2017-01-13 12:09:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2629853003/20001
3 years, 11 months ago (2017-01-13 12:15:34 UTC) #5
commit-bot: I haz the power
3 years, 11 months ago (2017-01-13 12:26:32 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/71db1d97d86d4bfa89edb4d8b7bb...

Powered by Google App Engine
This is Rietveld 408576698