Add NOTREACHED to HeapObjectHeader::markDead()

Add NOTREACHED to HeapObjectHeader::markDead()

Now that we've shipped a per-thread heap, a Dead state should not happen.
This CL adds an assert to check the fact.

BUG=

Review-Url: https://codereview.chromium.org/2629853002
Cr-Commit-Position: refs/heads/master@{#443514}
Committed: https://chromium.googlesource.com/chromium/src/+/87a6ab3424caa36f6d65405f7065ca20a1b90cf2

[haraken, 2017-01-13 05:39:32]

The CQ bit was checked by haraken@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-01-13 05:39:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 07:04:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-01-13 07:04:24]

Dry run: This issue passed the CQ dry run.

[haraken, 2017-01-13 07:05:01]

haraken@chromium.org changed reviewers:
+ sigbjornf@opera.com

[haraken, 2017-01-13 07:05:01]

PTAL

I want to land this just in case before completely removing the Dead state from
the infrastructure.

[sof, 2017-01-13 07:21:22]

lgtm

[haraken, 2017-01-13 07:28:21]

The CQ bit was checked by haraken@chromium.org

[commit-bot: I haz the power, 2017-01-13 07:28:28]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-01-13 07:32:17]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1484292501108340,
"parent_rev": "cc53e06971c8c55c85642a44fd350ebc092a5e8c", "commit_rev":
"87a6ab3424caa36f6d65405f7065ca20a1b90cf2"}

[commit-bot: I haz the power, 2017-01-13 07:32:44]

Description was changed from

==========
Add NOTREACHED to HeapObjectHeader::markDead()

Now that we've shipped a per-thread heap, a Dead state should not happen.
This CL adds an assert to check the fact.

BUG=
==========

to

==========
Add NOTREACHED to HeapObjectHeader::markDead()

Now that we've shipped a per-thread heap, a Dead state should not happen.
This CL adds an assert to check the fact.

BUG=

Review-Url: https://codereview.chromium.org/2629853002
Cr-Commit-Position: refs/heads/master@{#443514}
Committed:
https://chromium.googlesource.com/chromium/src/+/87a6ab3424caa36f6d65405f7065...
==========

[commit-bot: I haz the power, 2017-01-13 07:32:45]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/87a6ab3424caa36f6d65405f7065...